Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to mirage-flow 4.0.0 changes: add a shutdown function #634

Merged
merged 5 commits into from
May 14, 2024

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented May 8, 2024

In the tests I was a bit sloppy and defined shutdown as close.

@hannesm
Copy link
Member Author

hannesm commented May 14, 2024

this is ready now, and a merge & release would be great. to allow mirage to use the new git-mirage then, a 3.15.1 release would be great (if it is 3.16.0, we'll need to adapt the bounds in mirage and cut another mirage release).

thanks for all the great work! :)

@hannesm
Copy link
Member Author

hannesm commented May 14, 2024

I updated the unikernels to mirage 4.5.0 :)

I also shaved some more unneeded dependencies.

this is good to be merged and released :)

@dinosaure dinosaure merged commit 33283ff into mirage:main May 14, 2024
1 check passed
@dinosaure
Copy link
Member

Thanks!

@hannesm hannesm deleted the mirage-flow4 branch May 14, 2024 10:11
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request May 17, 2024
CHANGES:

- Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634)
- Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635)
- Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request May 17, 2024
CHANGES:

- Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634)
- Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635)
- Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
dinosaure added a commit that referenced this pull request May 19, 2024
Adapt to mirage-flow 4.0.0 changes: add a shutdown function
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request May 19, 2024
CHANGES:

- Remove the `result` dependency (@hannesm, mirage/ocaml-git#634)
- Split out `carton` into `https://git.robur.coop/robur/carton` (@dinosaure)
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request May 24, 2024
CHANGES:

- Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634)
- Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635)
- Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
CHANGES:

- Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634)
- Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635)
- Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants