-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to mirage-flow 4.0.0 changes: add a shutdown function #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is ready now, and a merge & release would be great. to allow mirage to use the new git-mirage then, a 3.15.1 release would be great (if it is 3.16.0, we'll need to adapt the bounds in mirage and cut another mirage release). thanks for all the great work! :) |
I updated the unikernels to mirage 4.5.0 :) I also shaved some more unneeded dependencies. this is good to be merged and released :) |
Thanks! |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
May 17, 2024
CHANGES: - Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634) - Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635) - Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
May 17, 2024
CHANGES: - Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634) - Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635) - Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
dinosaure
added a commit
that referenced
this pull request
May 19, 2024
Adapt to mirage-flow 4.0.0 changes: add a shutdown function
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
May 19, 2024
CHANGES: - Remove the `result` dependency (@hannesm, mirage/ocaml-git#634) - Split out `carton` into `https://git.robur.coop/robur/carton` (@dinosaure)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
May 24, 2024
CHANGES: - Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634) - Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635) - Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: - Adapt `ocaml-git` to `mirage-flow.4.0.0` (@hannesm, mirage/ocaml-git#634) - Improve the documentation (@Leonidas-from-XIV, mirage/ocaml-git#635) - Explicitely add `unix` as a dependency of some ocaml-git's targets (@dinosaure, b2288c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tests I was a bit sloppy and defined shutdown as close.