conduit-lwt-unix: adapt to tls 0.14.0 API#396
Merged
Conversation
hannesm
force-pushed
the
new-tls
branch
3 times, most recently
from
dac7d0c to
0f8838f
Compare
Member
Author
|
anyone up for a quick review (+merge +release) to unlock the ecosystem with the new tls version? When looking at the code, I'm slightly confused why there is a multitude of constructors (Tls, Tls_native, OpenSSL), all using the same tls_server_config/tls_client_config. I intended to use the |
dinosaure
reviewed
Aug 3, 2021
Member
|
To avoid any conflicts for further releases, I will cut a minor release with your patch. Do you agree @avsm? |
Member
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Aug 6, 2021
…nd conduit-mirage (4.0.1) CHANGES: * Add missing `ipaddr-sexp` dependency on conduit-async (mirage/ocaml-conduit#385, @anmonteiro) * Update the link of the documentation (959f57a & mirage/ocaml-conduit#398, reported by @misterfish, @zshipko, @dinosaure) * Gitignore `opam/` even if it is a symlink (mirage/ocaml-conduit#394, @craigfe, @avsm) * Adapt `conduit-lwt-unix` to `tls.0.14.0` (mirage/ocaml-conduit#396, @hannesm, @dinosaure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ocaml/opam-repository#19175