Allow openssl conduit-lwt-unix users to control their client Ssl.contexts#389
Closed
lippirk wants to merge 1 commit into
Closed
Allow openssl conduit-lwt-unix users to control their client Ssl.contexts#389lippirk wants to merge 1 commit into
lippirk wants to merge 1 commit into
Conversation
…exts I am making this patch because I'd like to be able to control the lifetime of my openssl client context directly. Motivation for this includes the fact that the global `Conduit_lwt_unix_ssl.Client.default_ctx` is not sufficient in the case that you want to update an ssl context's verify location (it is necessary to use a new ssl context). Example usage with cohttp: ``` (* three types of context :D *) let client_ssl_context : Ssl.context = Conduit_lwt_unix_ssl.Client.create_ctx () in (* some ssl setup *) let* (ctx : Conduit_lwt_unix.ctx) = Conduit_lwt_unix.init ~client_ssl_context () in let ctx : Cohttp_lwt_unix.Client.ctx = Cohttp_lwt_unix.Client.custom_ctx ~ctx () in let* _ = Cohttp_lwt_unix.Client.call ~ctx `POST ~body:"blah" uri in ... ```
Author
|
closing in favour of #390 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am making this patch because I'd like to be able to control the
lifetime of my openssl client context directly.
Motivation for this includes the fact that the global
Conduit_lwt_unix_ssl.Client.default_ctxis not sufficient in the casethat you want to update an ssl context's verify location (it is
necessary to use a new ssl context).
Example usage with cohttp: