more cleanups: reorg files and compile tests#374
Merged
Conversation
ec61582 to
17a616f
Compare
aebcabb to
c021ed9
Compare
Member
|
This PR introduced a module |
Member
Author
|
What does it break? Happy to revert it if that's an issue |
Member
|
tls 0.13.0 removed the type aliases (X509_lwt.priv), since that tuple type was revised (now that ECDSA certificates and keys are possible) - and I didn't see the value of an alias to the |
Member
Author
|
is there any other aliases that can removed in https://github.com/mirage/ocaml-conduit/blob/master/src/conduit-lwt-unix/conduit_lwt_tls.real.mli#L20-L26 ? What about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only compile the lwt-unix and async tests as the mirage tests are a bit harder to compile. Also we do not run the tests -- might be worth cherry-picking the changes that happened on
masterfor this if really necessary.