Skip to content

more cleanups: reorg files and compile tests#374

Merged
samoht merged 1 commit into
mirage:v2from
samoht:reorg-and-compile-tests
Jan 30, 2021
Merged

more cleanups: reorg files and compile tests#374
samoht merged 1 commit into
mirage:v2from
samoht:reorg-and-compile-tests

Conversation

@samoht
Copy link
Copy Markdown
Member

@samoht samoht commented Jan 30, 2021

Only compile the lwt-unix and async tests as the mirage tests are a bit harder to compile. Also we do not run the tests -- might be worth cherry-picking the changes that happened on master for this if really necessary.

@samoht samoht force-pushed the reorg-and-compile-tests branch 6 times, most recently from ec61582 to 17a616f Compare January 30, 2021 17:09
@samoht samoht force-pushed the reorg-and-compile-tests branch from aebcabb to c021ed9 Compare January 30, 2021 17:51
@samoht samoht merged commit 4ca5887 into mirage:v2 Jan 30, 2021
@hannesm
Copy link
Copy Markdown
Member

hannesm commented Apr 14, 2021

This PR introduced a module X509 in Conduit_lwt_tls.real.mli (and ml) -- is there a reason for this? can we remove it (is it already used elsewhere)?

@samoht
Copy link
Copy Markdown
Member Author

samoht commented Apr 14, 2021

What does it break? Happy to revert it if that's an issue

@hannesm
Copy link
Copy Markdown
Member

hannesm commented Apr 14, 2021

tls 0.13.0 removed the type aliases (X509_lwt.priv), since that tuple type was revised (now that ECDSA certificates and keys are possible) - and I didn't see the value of an alias to the Tls.Config.certchain type.

@samoht
Copy link
Copy Markdown
Member Author

samoht commented Apr 14, 2021

is there any other aliases that can removed in https://github.com/mirage/ocaml-conduit/blob/master/src/conduit-lwt-unix/conduit_lwt_tls.real.mli#L20-L26 ? What about X509.Authenticator.t ? I think I've just added this because I didn't know it was an alias :-) feel free to change to something better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants