Get client IP when using TLS/SSH connections#277
Merged
Conversation
|
what's keeping back from merging this? |
Member
|
@Silur a lack of review and testing time. Have you tried this patch and can you report anything about it? |
Contributor
Author
|
I've been using this patch in our server: https://cerberus.cl.cam.ac.uk |
|
I was directed here from issue number #286 |
|
will there be anything of this? |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Aug 17, 2019
… conduit-lwt-unix (2.0.0) CHANGES: * lwt-unix: obtain client IP correctly when using TLS connections (mirage/ocaml-conduit#277 @victorgomes) * lwt-unix: replace the dune/ocaml file with a `(select)` build form. This avoids invoking `ocamlfind` from the build, and fits in with the rest of dune builds much more naturally (@avsm). * lwt-unix: force callers to give a custom callback `on_exn` in case of exceptions to avoid random crashes (mirage/ocaml-conduit#261 @kit-ty-kate) * mirage: use `dns-client>=4.0.0` which is the `udns` implementation (mirage/ocaml-conduit#290 @hannesm) * mirage: rename `mirage-conduit` to `conduit-mirage` to fit the naming structure of this library suite more. All new users of Mirage should use `conduit-mirage`, and migrating should involve simply swapping the name in your `dune` and `opam` files (mirage/ocaml-conduit#302 @hannesm @avsm) * async: expose `verify_mode` correctly in `Conduit_async` (mirage/ocaml-conduit#298 @brendanlong)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to issue #188
The client IP and port wasn't properly propagated.