Skip to content

Fix descriptor leak on thread cancellation for the Lwt client #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hcarty wants to merge 1 commit into from
Closed

Fix descriptor leak on thread cancellation for the Lwt client #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lwt-core/cohttp_lwt.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ module Make_client
closefn ();
return (res, `Empty)
end
let read_response ~closefn ic oc meth =
let t = read_response ~closefn ic oc meth in
Lwt.on_termination t closefn;
t

let is_meth_chunked = function
| `HEAD -> false
Expand Down