Skip to content

Fix handling of 1xx/204/304: there is no message body #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 1 commit into from
May 28, 2015
Merged

Fix handling of 1xx/204/304: there is no message body #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/response.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ module Make(IO : S.IO) = struct
let flush = false in
return (`Ok { encoding; headers; version; status; flush })

let has_body {encoding} = Transfer.has_body encoding
let has_body {status; encoding} =
(* rfc7230#section-5.7.1 *)
match status with
| #Code.informational_status | `No_content | `Not_modified -> `No
| #Code.status_code -> Transfer.has_body encoding
let make_body_reader {encoding} ic = Transfer_IO.make_reader encoding ic
let read_body_chunk = Transfer_IO.read

Expand Down