Skip to content

Actually installs binaries fixing regression in bd626e for #252 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avsm merged 1 commit into from
Apr 3, 2015
Merged

Actually installs binaries fixing regression in bd626e for #252 #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions cohttp.install
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
bin: [
"?cohttp-server-async"
"?cohttp-server-lwt"
"?cohttp-curl-async"
"?cohttp-curl-lwt"
"?cohttp-proxy-lwt"
"?cohttp_server_async.byte" { "cohttp-server-async" }
Copy link
Copy Markdown
Member

@avsm avsm Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the ordering matter? I'd prefer to install native code ones rather than bytecode.

Copy link
Copy Markdown

@dbuenzli dbuenzli Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opam manual says that files will be installed in sequence. https://opam.ocaml.org/doc/manual/dev-manual.html#sec25

Copy link
Copy Markdown
Member Author

@dsheets dsheets Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the order matters but _oasis is targeting best so only one of these should exist.

Copy link
Copy Markdown

@dbuenzli dbuenzli Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though personally I don't find that relying on this property is very clean, that's the reason why .install files should really be generated by the build system).

Copy link
Copy Markdown
Member Author

@dsheets dsheets Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I've reordered it but GitHub is having some trouble with the force push.

"?cohttp_server_async.native" { "cohttp-server-async" }

"?cohttp_server_lwt.byte" { "cohttp-server-lwt" }
"?cohttp_server_lwt.native" { "cohttp-server-lwt" }

"?cohttp_curl_async.byte" { "cohttp-curl-async" }
"?cohttp_curl_async.native" { "cohttp-curl-async" }

"?cohttp_curl_lwt.byte" { "cohttp-curl-lwt" }
"?cohttp_curl_lwt.native" { "cohttp-curl-lwt" }

"?cohttp_proxy_lwt.byte" { "cohttp-proxy-lwt" }
"?cohttp_proxy_lwt.native" { "cohttp-proxy-lwt" }
]