0.16.0#283
Merged
Merged
Conversation
With the Lwt backend, reads hang if trying to fetch more than Sys.max_string_length due to a byte allocation failure in Lwt_io.read. Problematic for large uploads, etc. Upper layer callers (eg, Transfer_io) seem to handle recombining these split reads without any issues.
* Parsing a request will end up with `//host/bar` instead of hardcoding `http://` now. * A `GET` request cannot have a body (and hence transfer encoding headers), so the manual request parser uses `POST` now.
Member
|
Don't forget #278 in CHANGES |
Member
Author
|
#248 is the only release blocker for 0.16.0 now i think. |
avsm
added a commit
that referenced
this pull request
Mar 22, 2015
|
@rgrinberg thanks, I'm glad to see it'll be included in 0.16.0 @avsm let me know if you're having issues reproducing #248 and I'll make a small test file to reproduce the bug. Currently it happens if I remove the call to |
Member
|
@SGrondin I think making a small test case for us would greatly ease fixing this problem. Note to mention that we'll be able to add it to our test suite to prevent regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated pull request for:
Compatibility breaking interface changes:
post_formto be astring * string listinsteadof a
Header.t(Fix type in post_form #257)Netsignature which needs to be provided for Lwt serversto not be required. Only the Lwt client needs a
Netfunctor argumentto make outgoing connections. (Simplify the Net signature which needs to be provided for lwt servers #274)
New features and bug fixes:
Uri.userinfointo the Authorization headerfor HTTP requests. (Copy basic auth from Uri.userinfo into Authorization header #255)
.installfile to ensure that they arereliably uninstalled. (Uninstalling cohttp doesn't remove binaries #252)
magic-mimelibrary to add a MIME type by probing filenameduring static serving in the Lwt/Async backends. (Will respond_file use magic-mime ? #260)
Cohttp.Header.add_opt_unless_existsto set a header only ifan override wasn't supplied, and to initialise a fresh Header value
if none is present.
post_formorredirect.Request.has_bodydoes not permit a body to be set for methods thatRFC7231 forbids from having one (
HEAD,GETandDELETE).Request.makedoes not inject atransfer-encodingheader if thereis no body present in the request (Transfer-Encoding Header is injected into responses #246).
Server.respondno longer overrides user-supplied headers thatspecify the
content-lengthortransfer-encodingheaders (Better Request handling of transfer-encoding #268).cohttp_server_lwtandcohttp_server_asyncnow include sizes indirectory listing titles