raise (Failure ..) -> failwith ..#245
Merged
Merged
Conversation
better written as failwith x
Member
Author
|
The travis failure is unrelated and should be ignored. |
There was a problem hiding this comment.
I'd rather say you are using exceptions for something unexceptional.
Member
Author
There was a problem hiding this comment.
Yes all of this stuff is very much less than ideal. I think we are saving the refactoring post 1.0 however.
Member
There was a problem hiding this comment.
why post 1.0? shouldn't such API changes (I suspect raise will be transformed to use an 'a option return type instead) be before 1.0?
Member
Author
There was a problem hiding this comment.
Well we did ask people to participate in making a checklist for 1.0:
and the issue wasn't included. I guess it's not too late now :P.
EDIT: Net isn't being exported so we can easily fix it now actually.
Member
Author
rgrinberg
added a commit
that referenced
this pull request
Jan 27, 2015
raise (Failure ..) -> failwith ..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple tweak