IPv6 support (work in progress) by nojb · Pull Request #70 · mirage/mirage-tcpip

nojb · 2014-10-03T12:38:13Z

Started working on adding IPv6 support (see #43). Right now there is very little code, but I wanted to put it here so that there is a central place for discussion for those interested.

Right now the code only handles incoming tcp and udp payloads when there are no ipv6 extensions present. I am looking into implementing icmp6 echo handling next.

mor1 · 2014-10-03T12:46:38Z

cool! notifying @yomimono as she had been interested in this too :)

yomimono · 2014-10-03T15:09:30Z

Excellent! Thanks for the ping @mor1, and for your work @nojb . :)

nojb · 2014-10-06T13:32:29Z

It is ... alive!

avsm · 2014-10-06T19:01:28Z

Yay!!

On 6 Oct 2014, at 14:32, Nicolas Ojeda Bar notifications@github.com wrote:

It is ... alive!

—
Reply to this email directly or view it on GitHub.

mor1 · 2014-10-06T19:05:07Z

cool. though it's now simply a Small Matter of Programming until the
nanobots take over of course.

http://xkcd.com/865/

On 6 October 2014 20:01, Anil Madhavapeddy notifications@github.com wrote:

Yay!!

On 6 Oct 2014, at 14:32, Nicolas Ojeda Bar notifications@github.com
wrote:

It is ... alive!

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub
#70 (comment).

Richard Mortier
mort@cantab.net

avsm · 2014-11-02T23:42:21Z

releasing 2.0.0 now, so can merge this to the master branch as wip quite soon...

nojb · 2014-11-03T10:57:17Z

Great! There is still some more work to do before this patch is ready for general consumption. At some point I will also submit a PR for an IPV6 signature for V2.mli.

Also related is integrating this to the existing (IPv4) codebase (making a common base signature for IPV4 and IPV6 and making UDP & TCP functors of that). This will require changes both to mirage-tcpip and mirage-types. But I am focused on getting IPv6 working well before concentrating on this.

Icmpv6 and Ipv6 will be implemented in the same module, and Ndv6 will be implemented in a different module, mirroring the existing Ipv4/Arpv4 arrangement.

This required shuffling code around quite a bit and in particular removing the module `Ndpv6' and `Routing' from the picture, leaving a single, monolithic module `Ipv6'. The reason is that IPv6, ICMPv6, and NDPv6 are actually all protocols lying on the same layer and there are a lot of cyclic dependencies between them. Later on it will be necessary to figure out a way to decouple the different modules but for now it is simpler to put everything in the same namespace.

nojb · 2014-11-30T00:18:39Z

I would suggest to merge this now (together with mirage/mirage#319). I reverted the changes to STACKV4 so that we can merge this with a minimum of disruption (in particular, no changes are needed for conduit and any layer above that). The only visible interface changes are:

IPV4.set_ipv4_* functions have been renamed IPV4.set_ip_* because they are shared between IPV4 and IPV6.
IPV4.get_ipv4 and get_ipv4_netmask now return a list of Ipaddr.V4.t (again because this is the common semantics with IPV6.)
Several types that had v4 in their names (like IPV4.ipv4addr) have lost that particle.

In mirage/mirage#319 I added some basic support for configuring IPv6 for those who want to experiment with it, but reverted any change to STACKV4. I would feel better if we merged this first, and then turned the attention to how to integrate/replace the STACKV4 signature. I have been working on that, but any change is going to be fairly disruptive and more discussion is needed anyway, as opposed to the current change set which should be pretty uncontroversial.

I also have a patch ready to update mirage-skeleton with respect to the small notational changes listed above.

PS: it would also be great if I could rearrange the directory structure of mirage-tcpip in a more systematic fashion, if no one is opposed to it.

mor1 · 2014-11-30T22:23:25Z

fwiw, i'm never opposed to rearrangement to increase systematicness (if
that's even a word ;)

On 30 November 2014 at 00:18, Nicolas Ojeda Bar notifications@github.com
wrote:

I would suggest to merge this now (together with mirage/mirage#319
mirage/mirage#319). I reverted the changes to
STACKV4 so that we can merge this with a minimum of disruption (in
particular, no changes are needed for conduit and any layer above that).
The only visible interface changes are:

IPV4.set_ipv4_* functions have been renamed IPV4.set_ip_* because
they are shared between IPV4 and IPV6.

IPV4.get_ipv4 and get_ipv4_netmask now return a list of Ipaddr.V4.t
(again because this is the common semantics with IPV6.)

In mirage/mirage#319 mirage/mirage#319 I added
some basic support for configuring IPv6 for those who want to experiment
with it, but reverted any change to STACKV4. I would feel better if we
merged this first, and then turned the attention to how to
integrate/replace the STACKV4 signature. I have been working on that, but
any change is going to be fairly disruptive and more discussion is needed
anyway, as opposed to the current change set which should be pretty
uncontroversial.

I also have a patch ready to update mirage-skeleton with respect to the
small notational changes listed above.

PS: it would also be great if I could rearrange the directory structure of
mirage-tcpip in a more systematic fashion, if no one is opposed to it.

Reply to this email directly or view it on GitHub
#70 (comment).

Richard Mortier
mort@cantab.net

Conflicts: CHANGES myocamlbuild.ml setup.ml

…merge Conflicts: _oasis _tags dhcp/dhcp_clientv4.ml lib/META lib/arpv4.ml lib/ethif.ml opam tcp/wire.ml

More complete docstrings will be added later.

avsm · 2014-12-12T11:59:10Z

Am seeing bad udp checksums (previously we didnt set them at all). Causes DHCP to drop. Investigating...

11:58:16.833225 IP (tos 0x0, ttl 38, id 8120, offset 0, flags [none], proto UDP (17), length 580)
    0.0.0.0.bootpc > broadcasthost.bootps: [bad udp cksum 0xeffa -> 0xfda0!] BOOTP/DHCP, Request from 52:c2:b4:0c:cf:32 (oui Unknown), length 552, xid 0x108d58df, secs 10, Flags [none] (0x0000)

nojb · 2014-12-12T12:15:52Z

Yes, we must set the UDP checksum because it is mandatory for IPv6. Strange, didn't see this in my testing. Will investigate on my side, it is probably an errant packet offset calculation. Will report back here.

nojb · 2014-12-12T12:22:56Z

I think that should fix the bug - but cannot test right now. Could you test to see if bug is gone?

nojb · 2014-12-12T12:50:41Z

I can confirm now that checksum calculation for UDP seems to be working. I tried a DHCP example and checksum was being calculated correctly. Either way, please let me know if it also works for you.

avsm · 2014-12-12T14:33:49Z

I have lunch and the bug is fixed. This is great burp! :-)

avsm · 2014-12-12T15:50:41Z

This introduces a 4.02.0 dependency I think, due to a module alias? Needs to work on 4.01.0 as well.

~~No, I do not think so. If I understand correctly the 4.02.0 module alias stuff only refines the typing of expressions such as module M = ....~~

You are right, this does not compile in 4.01.0. Submitted a fix in #91.

Thanks!

On 13 Dec 2014, at 14:16, Nicolas Ojeda Bar notifications@github.com wrote:

In lib/ndpv6.ml:

https://tools.ietf.org/html/rfc2462
+
+- Neighbor Discovery for IP Version 6 (IPv6)

https://tools.ietf.org/html/rfc2461
+
+- Internet Control Message Protocol (ICMPv6) for the Internet Protocol Version 6 (IPv6) Specification

http://tools.ietf.org/html/rfc2463
+
+- IPv6 Node Requirements

http://tools.ietf.org/html/rfc6434
+
+- Multicast Listener Discovery Version 2 (MLDv2) for IPv6

http://tools.ietf.org/html/rfc3810
+*)
+
+module Ipaddr = Ipaddr.V6
You are right, this does not compile in 4.01.0. Submitted a fix in Ipv6: Fix compilation on 4.01.0 #91.

—
Reply to this email directly or view it on GitHub.

nojb mentioned this pull request Nov 10, 2014

RFC: Initial support for IPv6 mirage/mirage#319

Merged

nojb added 22 commits November 11, 2014 09:41

Add cstruct for ipv6 packet header

66a476a

Initial commit of IPV6 module

0f9468b

Add cstruct for icmpv6

93b147f

Add ipv6 checksum computation

c0d7133

Drop icmp6 packet if checksums don't match

ec87c2e

Add NS output routine

ea8cbcf

Handle inbound NA messages

31c5256

Add some debug statements

002f41c

Rearrange code

cb418ac

Icmpv6 and Ipv6 will be implemented in the same module, and Ndv6 will be implemented in a different module, mirroring the existing Ipv4/Arpv4 arrangement.

Add Routing + dummy `create' for testing

acdca4f

Rename for clarity

748db18

Fix protocol number

dbd8756

Add reference

75dff18

Add `allocate_frame' routine

2342b7e

Add `write' routine

2e59ce9

Respond to ICMP Echo requests

9edf611

Compute link-local address

fff7e43

Set default ip, gateway list

1f6aa4e

Make `allocate_frame' pure

c4ae3d8

Rewrite in pure style (WIP)

a019198

Improve handling of unsolicited NS, RA, Redirect

340e33b

nojb added 3 commits November 29, 2014 23:52

IPV4: Fix ARPV4

33cc4a2

Example: Make compilable again

abeb0ec

Fix typo

450949f

nojb added 15 commits December 1, 2014 15:08

Socket: Fix type constraints

e25e143

Ipv6: Refactor

8a195b3

Ipv6: Improve log messages

a100a06

Ndpv6: remove signatures from implementation

93af343

Ipv6: fix hop lim in pong packets

5053b7b

Ipv6: fix packet queueing order

59d12fc

Ipv6: move ndp_option to Parser.option

1c67324

Ipv6: Clarify processing of RA options

4ca19fa

Ndpv6: more precise signatures + some docs

95ba321

Ipv6: more docs

90be6cb

Ipv6: implement AddressList.handle_na

4306b9b

Merge branch 'master' of https://github.com/mirage/mirage-tcpip

d296782

Conflicts: CHANGES myocamlbuild.ml setup.ml

Merge branch 'ipv6-refactor'

b319f2d

Merge branch 'master' of https://github.com/mirage/mirage-tcpip into …

ec3c341

…merge Conflicts: _oasis _tags dhcp/dhcp_clientv4.ml lib/META lib/arpv4.ml lib/ethif.ml opam tcp/wire.ml

Ipv6: Remove old docstrings

9ca0477

More complete docstrings will be added later.

nojb mentioned this pull request Dec 11, 2014

Update to work with latest signatures mirage/mirage-skeleton#61

Merged

Udp: Fix checksum calculation

f0fdfe3

Udp: Further fix for checksum calculation

df16025

avsm merged commit df16025 into mirage:master Dec 12, 2014

avsm reviewed Dec 12, 2014
View reviewed changes

Conversation

nojb commented Oct 3, 2014

Uh oh!

mor1 commented Oct 3, 2014

Uh oh!

yomimono commented Oct 3, 2014

Uh oh!

nojb commented Oct 6, 2014

Uh oh!

avsm commented Oct 6, 2014

Uh oh!

mor1 commented Oct 6, 2014

Uh oh!

avsm commented Nov 2, 2014

Uh oh!

nojb commented Nov 3, 2014

Uh oh!

nojb commented Nov 30, 2014

Uh oh!

mor1 commented Nov 30, 2014

Uh oh!

avsm commented Dec 12, 2014

Uh oh!

nojb commented Dec 12, 2014

Uh oh!

nojb commented Dec 12, 2014

Uh oh!

nojb commented Dec 12, 2014

Uh oh!

avsm commented Dec 12, 2014

Uh oh!

avsm Dec 12, 2014

Choose a reason for hiding this comment

Uh oh!

nojb Dec 12, 2014

Choose a reason for hiding this comment

Uh oh!

nojb Dec 13, 2014

Choose a reason for hiding this comment

Uh oh!

avsm Dec 13, 2014

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants