bindings Makefile: only invoke opam var prefix if opam is available#79
Merged
Conversation
Such a change has been trickled through other MirageOS3 cross-compilation Makefiles as well. Also, use `opam var prefix`, not the deprecated `opam config var prefix`. This also allows clean NixOS compilation. Adapted from mirage-xen 49eda0949ff91f8b4dae5d01e509592b541a8e96
hannesm
force-pushed
the
no-opam-if-pkg-config
branch
from
a0af003 to
d5edc93
Compare
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 18, 2021
CHANGES: * Add caml_get_wall_clock to retrieve the wall clock as int64 (mirage/mirage-solo5#73 @hannesm) * Remove checksum_stubs, now available through tcpip (mirage/mirage-solo5#75 @dinosaure) * Remove alloc_pages_stubs, now available through io-page (mirage/mirage-solo5#76 @dinosaure) * Don't require opam for the bindings compilation (mirage/mirage-solo5#79 @hannesm)
arbipher
pushed a commit
to arbipher/opam-repository
that referenced
this pull request
Nov 21, 2021
CHANGES: * Add caml_get_wall_clock to retrieve the wall clock as int64 (mirage/mirage-solo5#73 @hannesm) * Remove checksum_stubs, now available through tcpip (mirage/mirage-solo5#75 @dinosaure) * Remove alloc_pages_stubs, now available through io-page (mirage/mirage-solo5#76 @dinosaure) * Don't require opam for the bindings compilation (mirage/mirage-solo5#79 @hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Such a change has been trickled through other MirageOS3 cross-compilation
Makefiles as well. Also, use
opam var prefix, not the deprecatedopam config var prefix. This also allows clean NixOS compilation.