Skip to content

Rename mirage-http to cohttp-mirage#247

Merged
djs55 merged 3 commits into
mirage:masterfrom
djs55:cohttp-mirage
Nov 15, 2017
Merged

Rename mirage-http to cohttp-mirage#247
djs55 merged 3 commits into
mirage:masterfrom
djs55:cohttp-mirage

Conversation

@djs55
Copy link
Copy Markdown
Member

@djs55 djs55 commented Nov 15, 2017

Related to [mirage/ocaml-cohttp#572]

Signed-off-by: David Scott dave@recoil.org

Related to [mirage/ocaml-cohttp#572]

Signed-off-by: David Scott <dave@recoil.org>
@djs55 djs55 force-pushed the cohttp-mirage branch 2 times, most recently from baeecd6 to e2dfbfc Compare November 15, 2017 14:51
@djs55
Copy link
Copy Markdown
Member Author

djs55 commented Nov 15, 2017

Unfortunately the PIN for cohttp-mirage blocks asking the user whether they want to define the package or not (since it doesn't exist yet in the opam-repository). I think I'll add something to mirage/opam-repo-dev

This is needed for cohttp-mirage: it's not possible to PIN and create
a new package because the CI blocks.

Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
@djs55 djs55 merged commit 33fe466 into mirage:master Nov 15, 2017
@djs55 djs55 deleted the cohttp-mirage branch November 15, 2017 20:40
@hannesm
Copy link
Copy Markdown
Member

hannesm commented Nov 16, 2017

@djs55 while I appreciate fixing for new package releases, I'm against that people merge their own PRs in this organisation (unless approved by someone else).

In this case, I still have in mind that the master branch of mirage-skeleton is supposed to work with packages released to the main opam repository (which is now no longer the case - cohttp-mirage is missing there, the mirage tool needs to be pinned as well) - whereas a dev branch in here should work with mirage-dev remote (that's where lock-step releases should be gathered). The reasoning behind this is that newcomers should have a pleasant experience when working on the tutorial - I'm aware that our state with OCaml 4.06.0 is not very good right now, but this PR made the experience using any other OCaml compiler bad as well.

@djs55
Copy link
Copy Markdown
Member Author

djs55 commented Nov 16, 2017

Sorry for any disruption caused -- I'm trying to complete the cohttp release to fix the -safe-string problem which has become urgent since the 4.06.0 release. Shall I move this branch to mirage-dev and restore master to the previous state in the meantime?

@djs55
Copy link
Copy Markdown
Member Author

djs55 commented Nov 16, 2017

To minimise disruption I've reverted master and pushed the changes to mirage-dev instead. I wonder if we could document the policy somewhere in this repo -- perhaps in a CONTRIBUTING.md?

I've also made

@hannesm
Copy link
Copy Markdown
Member

hannesm commented Nov 16, 2017

@djs55 thanks (both for your 4.06 safe-string work, and for reverting the master branch here to something which works with packages from opam-repository)! The information used to be part of README.md (which used to be different (pointing to mirage-dev repo) in the mirage-dev branch). I agree that we should revive this information either in README or create a CONTRIBUTING file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants