Skip to content

Fixes to build against Solo5 targets#181

Merged
mato merged 3 commits into
mirage:mirage-devfrom
mato:solo5-fixes
Sep 7, 2016
Merged

Fixes to build against Solo5 targets#181
mato merged 3 commits into
mirage:mirage-devfrom
mato:solo5-fixes

Conversation

@mato
Copy link
Copy Markdown
Contributor

@mato mato commented Sep 1, 2016

These changes fix the build with MODE=ukvm and MODE=virtio.

@yomimono Could you please check I'm doing the right thing in 9073886 and not papering over a dependency problem in the mirage frontend for the Solo5 targets. (See also #177)

@mato
Copy link
Copy Markdown
Contributor Author

mato commented Sep 1, 2016

Regarding the io-page dependency, for kv_ro, shouldn't this be pulled in by https://github.com/mirage/mirage/blob/master/lib/mirage.ml#L174? For some reason that's not happening, hence #177.

@yomimono
Copy link
Copy Markdown
Contributor

yomimono commented Sep 1, 2016

I think your suspicion about papering over a dependency problem in the mirage frontend for solo5 is warranted; mirage configure should really be figuring out that you want crunch, and that crunch needs io-page. I happened to be looking at #177 yesterday and got to the same point as your comment, but not further; I'll dig a bit deeper today. io-page has gotten preferential treatment in the xen case in the past, but I'm not sure whether that behavior is preserved in the Functoria version of Mirage.

@yomimono
Copy link
Copy Markdown
Contributor

yomimono commented Sep 1, 2016

mirage/mirage#585 for some investigation and a proposed fix for kv_ro; it definitely should be fixed in mirage instead of here.

@yomimono
Copy link
Copy Markdown
Contributor

yomimono commented Sep 6, 2016

@mato, want to force-push without the last commit? I just merged the fix for io-page's dependencies in mirage, so it shouldn't be needed anymore.

@mato
Copy link
Copy Markdown
Contributor Author

mato commented Sep 7, 2016

@yomimono Re-pushed, I still need eaf4394 to get the io_page example to build, I think there's no way around that. (Tried mucking with adding default_io_page in there but couldn't get the types right...)

@Drup
Copy link
Copy Markdown
Member

Drup commented Sep 7, 2016

Where does the dependency comes from ?

@mato
Copy link
Copy Markdown
Contributor Author

mato commented Sep 7, 2016

@Drup
Copy link
Copy Markdown
Member

Drup commented Sep 7, 2016

Ah, then it's fine to manually add it.

@mato mato merged commit bf72297 into mirage:mirage-dev Sep 7, 2016
@mato mato deleted the solo5-fixes branch September 7, 2016 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants