You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These changes fix the build with MODE=ukvm and MODE=virtio.
@yomimono Could you please check I'm doing the right thing in 9073886 and not papering over a dependency problem in the mirage frontend for the Solo5 targets. (See also #177)
I think your suspicion about papering over a dependency problem in the mirage frontend for solo5 is warranted; mirage configure should really be figuring out that you want crunch, and that crunch needs io-page. I happened to be looking at #177 yesterday and got to the same point as your comment, but not further; I'll dig a bit deeper today. io-page has gotten preferential treatment in the xen case in the past, but I'm not sure whether that behavior is preserved in the Functoria version of Mirage.
@yomimono Re-pushed, I still need eaf4394 to get the io_page example to build, I think there's no way around that. (Tried mucking with adding default_io_page in there but couldn't get the types right...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix the build with
MODE=ukvmandMODE=virtio.@yomimono Could you please check I'm doing the right thing in 9073886 and not papering over a dependency problem in the
miragefrontend for the Solo5 targets. (See also #177)