Release 1.3.0#18
Merged
Merged
Conversation
This avoids a deadlock due to the old code being able to refill the ring, draining it entirely (in rx_poll) and then blocking in Activations. There is a larger fix required to address that we are dropping into Activations too much in this code, since we are not checking if work is coming in on the ring after a poll. Bug found by Masoud Koleini in mirage#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to notice when space became available. (poll_thread indefinitely waits for a new event #15)
and simplicity. (Copy out-bound data into pre-shared pages #17)