Tasks should be transmitted with DELETE requests, too#227
Merged
Conversation
Member
|
a workaround is to not use DELETE and use POST everywhere ... |
Member
Author
|
It is true that What would you like to do? |
Member
|
Depends if we can have a quick point release for cohttp or not. But I'm fine to use pinning. |
Without this, delete requests over HTTP use the previous store task which is often the server store creation task. Requires mirage/ocaml-cohttp#383.
dsheets
force-pushed
the
http-delete-task
branch
from
f3b8f54 to
6cf6869
Compare
Merged
samoht
added a commit
that referenced
this pull request
Jul 14, 2015
Tasks should be transmitted with DELETE requests, too
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, delete requests over HTTP use the previous store task
which is often the server store creation task. Requires mirage/ocaml-cohttp#383.
Some of the code in
Irmin_http_servercommon toPOSTandDELETEprocessing could be factored.