-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove irmin-http #1902
Remove irmin-http #1902
Conversation
c9b9fc5
to
827b225
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1902 +/- ##
==========================================
+ Coverage 68.16% 68.80% +0.63%
==========================================
Files 137 132 -5
Lines 16652 16165 -487
==========================================
- Hits 11351 11122 -229
+ Misses 5301 5043 -258
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
46da26f
to
3da86cc
Compare
Will merge this once |
Hm, yeah this can be closed but there could also be a case to be made for removing |
Got it. As long as these ship together in a release, I'm fine to keep them separate PRs. Could you make #2031 just about adding |
CHANGES: ### Added - **irmin-server** - Added `irmin-server` package (mirage/irmin#2031, @zshipko) - **irmin-client** - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031, @zshipko) - **irmin** - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when using `utop` (@metanivek, mirage/irmin#1839) ### Fixed - **irmin-pack** - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek) ### Removed - **irmin-http** - Removed `irmin-http` since it is not compatible with generic keys. `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko) - **irmin** - Removed stream proofs. We now only have Merkle tree proofs. This simplifies the maintenance of that part of the code, as ensuring the correct order of cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht) ### Changed - **irmin-git** - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
CHANGES: ### Added - **irmin-server** - Added `irmin-server` package (mirage/irmin#2031, @zshipko) - **irmin-client** - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031, @zshipko) - **irmin** - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when using `utop` (@metanivek, mirage/irmin#1839) ### Fixed - **irmin-pack** - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek) ### Removed - **irmin-http** - Removed `irmin-http` since it is not compatible with generic keys. `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko) - **irmin** - Removed stream proofs. We now only have Merkle tree proofs. This simplifies the maintenance of that part of the code, as ensuring the correct order of cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht) ### Changed - **irmin-git** - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
irmin-http
since it no longer works with generic key storesirmin-graphql
should be the preferred method of interacting with a remote irmin store using high-level operationsirmin-server
/irmin-client
should be used instead ofirmin-http
for low-level operations. Bothirmin-http
andirmin-server
provide clients that implementIrmin.S
, howeverirmin-server
is more optimized and also provides aBatch
API that can be used to reduce the number of requests needed to perform an operation.