Skip to content

Re-enable Appveyor CI#1067

Closed
craigfe wants to merge 1 commit into
masterfrom
explicitly-test-appveyor
Closed

Re-enable Appveyor CI#1067
craigfe wants to merge 1 commit into
masterfrom
explicitly-test-appveyor

Conversation

@craigfe
Copy link
Copy Markdown
Member

@craigfe craigfe commented Aug 18, 2020

Fix #963.

Currently a draft as there are no changes... The name of this branch should trigger Appveyor CI on master so we can se what problems currently exist.

@craigfe craigfe added the no-changelog-needed No changelog is needed here label Aug 18, 2020
@craigfe
Copy link
Copy Markdown
Member Author

craigfe commented Aug 18, 2020

The CI jobs have now been queued for 30 minutes without starting.... Not a good start 😕

@samoht
Copy link
Copy Markdown
Member

samoht commented Aug 18, 2020

Still no sign of appveyor :-/ Maybe faster to add windows workers to the CI :p

@craigfe
Copy link
Copy Markdown
Member Author

craigfe commented Aug 18, 2020

Passed after ~3 hours (with 45 minutes of actual CI time). That suggests that #963 might have fixed itself, but I'm not sure I want to add a 3 hour CI loop to the repository.

What does everyone else think?

@samoht
Copy link
Copy Markdown
Member

samoht commented Aug 19, 2020

A ~3h feedback loop is way too long. I'm thinking of ditching Travis support out instead to only keep the fast feedback loop.

Is there anything that Travis is doing here that ocaml-ci is not doing yet?

@craigfe
Copy link
Copy Markdown
Member Author

craigfe commented Aug 19, 2020

Is there anything that Travis is doing here that ocaml-ci is not doing yet?

Yes. ocaml-ci does not install packages and run tests separately for each package as Travis does. This means that Travis ends up catching quite a lot of Opam metadata bugs that we would otherwise only find out about during the release: e.g. #1064.

@craigfe
Copy link
Copy Markdown
Member Author

craigfe commented Aug 25, 2020

Closing this as it doesn't seem likely that we'll be re-adding AppVeyor any time soon. We can purge it completely once OCaml-CI has Windows support.

@craigfe craigfe closed this Aug 25, 2020
@craigfe craigfe deleted the explicitly-test-appveyor branch April 29, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed No changelog is needed here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Appveyor CI fails erroneously

2 participants