Update irmin to the last version of ocaml-git#1065
Conversation
If you want to get the CI to work, you can add |
|
|
Re-updated to the last version of |
f4a1fcd to
933bea6
Compare
|
Ready to review 👍., |
|
Thanks for the patch. My main concern is that I would like to avoid |
de0e98e to
369edbe
Compare
I'm not sure, even if |
|
Could you also add a line in the changelog (and point to https://github.com/mirage/irmin/issues?q=is%3Aissue+is%3Aopen+git+label%3Agit which would probably be fixed 🎉) ? After that I think we are good to merge. |
I reverted the patch on |
|
So my revert seems good. However, I don't think that this PR fixes #914 or #917 (but #1001 is fixed according to a test in |
|
According to the release of |
|
Can you fix |
|
It's done 👍. |
|
LGTM, thanks! |
This is a draft about an update to the new version of git presented on mirage/ocaml-git#395 and the new version of conduit presented on mirage/ocaml-conduit#311 (including patches into mirage/ocaml-cohttp#692). I think the patch is small enough. The CI will fail but locally (with a
pinofconduitandcohttpand a simpledune runtest) it's work (believe me).This is a draft but people can start to comment it if some details are obscures. Currently, the biggest change is about the synchronization where I updated the interface which seems to be much more simpler.