Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show play/stop for unconfigured decklink #797

Closed
wants to merge 0 commits into from

Conversation

ElderOrb
Copy link
Collaborator

No description provided.

@ElderOrb ElderOrb self-assigned this Dec 11, 2023
@ElderOrb ElderOrb requested a review from dericed December 11, 2023 19:27
@dericed
Copy link
Contributor

dericed commented Dec 11, 2023

In this case, when the user clicks stop and there's no control to decklink, then the gui sends /usr/local/bin/dvrescue device://84:3c0a102a:00000000 --decklink-video-mode ntsc --decklink-video-source sdi --decklink-audio-source embedded --decklink-timecode-format vitc -cmd stop. This doesn't do anything since there's no control, what should happen here is that pressing stop stops the active recording command.

So,

  if decklink is not recording; then
    if no control; then
       stop should be grayed out
    elif if control; then 
       stop should be active and a press sends `-cmd stop`
    fi
  else # aka decklink is recording
    if no control; then
       stop should be active and a press stops the active recording command
    elif if control; then 
       stop should be active and a press stops the active recording command and sends `-cmd stop`
    fi
fi

@ElderOrb ElderOrb closed this Mar 12, 2024
@ElderOrb ElderOrb force-pushed the start_stop_for_decklink branch from 6ab4203 to 06f1b1f Compare March 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants