This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Scheduled / Recurring jobs #32
Draft
jpbruinsslot
wants to merge
21
commits into
main
Choose a base branch
from
feature/scheduled-jobs-rebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
reviewed
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff already. Some remarks while looking through the code
scheduler/context/context.py
Outdated
@@ -52,8 +52,8 @@ def __init__(self) -> None: | |||
orgs=svc_katalogus.get_organisations(), | |||
) | |||
|
|||
lst_scan_profile = listeners.ScanProfile( | |||
dsn=self.config.host_scan_profile, | |||
lst_mutations = listeners.ScanProfileMutation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
lst_mutations = listeners.ScanProfileMutation( | |
mutations = listeners.ScanProfileMutation( |
36 tasks
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: ammar92 <[email protected]>
…ed-jobs-rebase * feature/refactor-boefje-scheduler: (27 commits) Fix reference Update notation Remove test database Update notation variables Fix type hint Fix reference to listener Black formatting Continue writing tests Fix import statement Continue writing tests for boefje scheduler Continue writing, updating tests Fix task type Continue writing tests Remove test database Add additional task list filters Overhaul tests Format code with black Use the scan profile mutation queue from octopoes Start with refactor based on feature/scheduled-jobs-rebase Merge release-1.4 into main (#25) ...
* main: Set deafult logging level to INFO Fix bytes tokene expiration issue Updated dependabot config Update scheduler/rankers/boefje.py Update scheduler/queues/pq.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.