Report types listed in a modal @ report plugins #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppvg
reviewed
Oct 23, 2024
ammar92
previously approved these changes
Oct 23, 2024
Checklist for QA:
What works:Seems to work as expected. What doesn't work:n/a Bug or feature?:n/a |
underdarknl
reviewed
Oct 28, 2024
Comment on lines
43
to
47
| <div class="dropdown-list" id="plugin-report-types"> | ||
| <ul> | ||
| {% for report_type in report_types %}<li>{{ report_type.name }}</li>{% endfor %} | ||
| </ul> | ||
| </div> |
There was a problem hiding this comment.
Should be a modal / dialog element.
There was a problem hiding this comment.
The dropdown implementation currently follows something resembling the APG Menu Button Pattern. Are you sure it should be a Dialog instead? If so, why?
…/nl-kat-coordination into feature/report-plugins-enhacement
Rieven
changed the title
…feature/report-plugins-enhacement01~
…ture/report-plugins-enhacement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added modal to list report types of report plugins.
Issue link
#3719
Closes #3719
Demo
QA notes
Run yarn dev or yarn build to see the changes. (clear cache needed maybe)
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.