-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi select dropdown #3446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
TwistMeister
approved these changes
Sep 10, 2024
Checklist for QA:
What works:Looks good. What doesn't work:n/a Bug or feature?:n/a |
underdarknl
approved these changes
Sep 11, 2024
Todo: (Feedback from @RomijnHumanoids)
Edit: As it's already merged I will add these fixes in a separate pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds styling needed for the multi select dropdown element. Fixes some of the existing components for consistency. Adds link hover state. (as it was needed within this component)
Design
https://www.figma.com/design/MDbpc9K0qjyaoRGAGiDX6t/%F0%9F%8E%A8-KAT-%7C-Design-System-%7C-Components?node-id=495-3013&node-type=CANVAS&t=aTq4lTB8lbrQ5ebl-0
Visual goal
This PR adds
This example uses tabler svg icon. (https://tabler.io/icons) Search for the icon and copy svg.
Please note that the label is added for screenreaders. While being visually hidden for sighted users. For the icon it's the other way around. It functions as the label for sighted users but is hidden for screen reader users through the use of aria-hidden.
Destructive state for links (for clear all for example)
<a href="#" class="destructive">Clear all</a>
Destructive state for buttons
<button class="destructive">Clear all</button>
Link example:
Hover:
Link within toolbar example:
Hover:
Button example:
Hover:
Ghost button example:
Hover:
Html for full multi select dropdown element
Issue link
You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.
Please add the link to the issue after "Closes".
Implements: #3040
Demo
Default state
Hover state on checkbox list
QA notes
Please note this element currently isn't implemented in the UI.
To test in the UI follow these steps:
1: Add the code from the "Html for full multi select dropdown element" block as previously mentioned.
2: Add it in the following file within rocky:
"/nl-kat-coordination/rocky/rocky/templates/partials/ooi_list_toolbar.html"
on line 6 (right under the following line: "<div class="horizontal-view toolbar">
" (so it's within the toolbar)4: Navigate to the object list page. You can get there by clicking on "objects" within the top navigation bar. (if you don't see "objects" click on one of your organisations)
3: A new toolbar option will appear. A button named "Object types (test). Click it to open the dropdown menu.
To test the destructive class you can add "destructive" as a class to a button or link.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.