-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure scheduler server module #3295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only the return types seem to be incorrect for the __init__
method and endpoint methods.
Other suggestions and ideas have been discussed offline and will be picked up later
I'll pick those up in #3162 as well, since I can remember something about that it was required to have the |
Co-authored-by: ammar92 <[email protected]> Co-authored-by: Jan Klopper <[email protected]>
Co-authored-by: LibreTranslate <[email protected]> Co-authored-by: alster <[email protected]> Co-authored-by: Weblate Translation Memory <[email protected]> Co-authored-by: Wim Benes <[email protected]> Co-authored-by: Jan Klopper <[email protected]>
Co-authored-by: Jan Klopper <[email protected]> Co-authored-by: Jeroen Dekkers <[email protected]>
|
The bugs when clicking on the objects from the tasks list are fixed. You can now click on the links and they will go to the corresponding page without showing an error message. |
* main: Restructure scheduler server module (#3295)
* feature/mula/refactor-queue: Restructure scheduler server module (#3295)
Changes
This pr restructures the rest API endpoints of the scheduler server. Prior to this pr all the routes, and endpoint handlers were present in one large file. With this pr it has been broken up in their respective folders and files. Note that the restructuring of serializers/models are not yet changed to resemble conventions used in the fastapi this will be picked up in #3162
QA notes
Since mainly the rest API endpoint are updated, the main QA points of attention would be that the scheduler would perform its normal procedures.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.