Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SonarCloud integrations #3001

Open
wants to merge 209 commits into
base: main
Choose a base branch
from
Open

Implement SonarCloud integrations #3001

wants to merge 209 commits into from

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented May 28, 2024

Changes

(draft) First steps to Sonar Cloud integration

Issue link

Please add a link to the issue after "Closes". If there is no issue for this PR, please add it to the project board directly.

Closes ...

Demo

Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

workflow_dispatch:
push:
branches: [main]
tags: [v*]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything about support for tags in the sonarcloud documenation. It does support branch analysis (https://docs.sonarsource.com/sonarcloud/enriching/branch-analysis/) so I think it makes more sense to run this on the release-* branches.

uses: actions/download-artifact@v4

- name: SonarCloud
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the if? It doesn't seem like this does anything and this isn't the sonarcloud documentation.

@ammar92 ammar92 marked this pull request as ready for review August 23, 2024 12:34
@ammar92 ammar92 requested a review from a team as a code owner August 23, 2024 12:34
Copy link

sonarcloud bot commented Sep 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants