-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SonarCloud integrations #3001
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/sonar-cloud.yml
Outdated
workflow_dispatch: | ||
push: | ||
branches: [main] | ||
tags: [v*] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find anything about support for tags in the sonarcloud documenation. It does support branch analysis (https://docs.sonarsource.com/sonarcloud/enriching/branch-analysis/) so I think it makes more sense to run this on the release-*
branches.
.github/workflows/sonar-cloud.yml
Outdated
uses: actions/download-artifact@v4 | ||
|
||
- name: SonarCloud | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the if? It doesn't seem like this does anything and this isn't the sonarcloud documentation.
# Conflicts: # mula/requirements-dev.txt
Quality Gate passedIssues Measures |
Changes
(draft) First steps to Sonar Cloud integration
Issue link
Please add a link to the issue after "Closes". If there is no issue for this PR, please add it to the project board directly.
Closes ...
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.