Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add community install/update scripts #1309

Merged
merged 39 commits into from
Aug 11, 2023
Merged

Add community install/update scripts #1309

merged 39 commits into from
Aug 11, 2023

Conversation

ring-ring-ring
Copy link
Contributor

added utilities document reference

@ring-ring-ring ring-ring-ring marked this pull request as ready for review July 3, 2023 13:30
@ring-ring-ring ring-ring-ring requested a review from a team as a code owner July 3, 2023 13:30
@ring-ring-ring
Copy link
Contributor Author

#1313 follows on this one

ammar92
ammar92 reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's indeed wait until the actual implementation is merged

@dekkers dekkers changed the title utilities Add community install/update scripts Jul 4, 2023
dekkers
dekkers reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@dekkers dekkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few small improvements / suggestions. In general it looks good. I just tested the scripts and they work.

docs/source/technical_design/community.rst Outdated Show resolved Hide resolved
docs/source/technical_design/community.rst Outdated Show resolved Hide resolved
docs/source/technical_design/community.rst Outdated Show resolved Hide resolved
docs/source/technical_design/utilities/scripts/openKAT_install.sh Outdated Show resolved Hide resolved
docs/source/technical_design/utilities/scripts/openKAT_install.sh Outdated Show resolved Hide resolved
docs/source/technical_design/utilities/scripts/openKAT_install.sh Outdated Show resolved Hide resolved
docs/source/technical_design/utilities/scripts/openKAT_install.sh Outdated Show resolved Hide resolved
docs/source/technical_design/utilities/scripts/openKAT_install.sh Outdated Show resolved Hide resolved
docs/source/technical_design/utilities/scripts/openKAT_install.sh Outdated Show resolved Hide resolved
docs/source/technical_design/utilities/scripts/openKAT_install.sh Outdated Show resolved Hide resolved
ammar92
ammar92 reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also wondering if the scripts are specific to Debian installations, then perhaps put them under utilities/scripts/debian?

@dekkers dekkers self-assigned this Jul 24, 2023
Darwinkel
Darwinkel approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@Darwinkel Darwinkel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved: I haven't tested every use case on every platform, but I was able to upgrade successfully to 1.10.1 on my Debian 12 VM, as well as re-install KAT.

Note that depending on whether this or #1517 is merged first, some minor variable name changes are needed.

@Darwinkel Darwinkel mentioned this pull request Aug 10, 2023
Closed
12 tasks
@underdarknl underdarknl merged commit 81166d3 into main Aug 11, 2023
5 checks passed
@underdarknl underdarknl deleted the ring-ring-ring-utilities branch August 11, 2023 15:33
jpbruinsslot pushed a commit that referenced this pull request Aug 14, 2023
@ring-ring-ring @RobboRob
@Darwinkel @underdarknl @dekkers @jpbruinsslot
Add community install/update scripts (#1309)
eb3779f 
Co-authored-by: Robjen <[email protected]>
Co-authored-by: Patrick Darwinkel <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Jan Klopper <[email protected]>
Co-authored-by: Jeroen Dekkers <[email protected]>
jpbruinsslot added a commit that referenced this pull request Aug 14, 2023
@jpbruinsslot
Merge branch 'main' into feature/mula/rate-limit-2
1dd2c00 
* main:
  Add sectxt dependency (#1610)
  Refactor environment settings, names, and documentation (#1517)
  Add pipeline to check if there are new translation strings (#1606)
  Translations update from Hosted Weblate (#1604)
  Update scheduler documentation (#1476)
  Add community install/update scripts (#1309)
  Bump actions/checkout from 1 to 3 (#1598)
  Run docker-compose pull in make pull (#1585)
  Configure github actions in dependabot (#1594)
  fix many ports open normalizer (#1592)
  Fix human-readable name for ImageMetadata (#1558)
  Upgrade FastAPI (#1576)
  OOI Detail page: Remember page position after clicking the "show inheritance" link (#1590)
  Fix `rstcheck` hook (#1584)
jpbruinsslot added a commit that referenced this pull request Aug 15, 2023
@jpbruinsslot
Merge branch 'main' into chore/mula/refactor
dd4dae7 
* main:
  Fix env setting issues found in test debian workflow (#1608)
  Add sectxt dependency (#1610)
  Refactor environment settings, names, and documentation (#1517)
  Add pipeline to check if there are new translation strings (#1606)
  Translations update from Hosted Weblate (#1604)
  Update scheduler documentation (#1476)
  Add community install/update scripts (#1309)
  Bump actions/checkout from 1 to 3 (#1598)
  Run docker-compose pull in make pull (#1585)
  Configure github actions in dependabot (#1594)
  fix many ports open normalizer (#1592)
  Fix human-readable name for ImageMetadata (#1558)
  Upgrade FastAPI (#1576)
  OOI Detail page: Remember page position after clicking the "show inheritance" link (#1590)
  Fix `rstcheck` hook (#1584)
  Manage boefjes requirements with Poetry (#1572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ITNerdbox ITNerdbox ITNerdbox left review comments

@dekkers dekkers dekkers left review comments

@Darwinkel Darwinkel Darwinkel approved these changes

@ammar92 ammar92 ammar92 approved these changes

@underdarknl underdarknl underdarknl approved these changes

Assignees

@dekkers dekkers

Labels
debian
Projects
KAT
Archived in project
Milestone
OpenKAT v1.11
Development

Successfully merging this pull request may close these issues.
7 participants
@ring-ring-ring @dekkers @underdarknl @ammar92 @Darwinkel @ITNerdbox @RobboRob