Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

feat(cvEntry): add url to link to ~company~ society #27

Closed
wants to merge 1 commit into from

Conversation

tinnet
Copy link
Contributor

@tinnet tinnet commented Jun 5, 2024

Hi, i added the option to pass an url to cvEntry that then gets linked on the society text.

Not sure if this is useful, since there's no style hint for recruiters to discover this, but i thought if they wonder about a company they might hover over it and be pleased to see it's clickable?

For you to decide if this is valuable :)

@tinnet tinnet changed the title add url to cvEntry feat(cvEntru): add url to link to ~company~ society Jun 5, 2024
@tinnet tinnet changed the title feat(cvEntru): add url to link to ~company~ society feat(cvEntry): add url to link to ~company~ society Jun 5, 2024
@mintyfrankie
Copy link
Owner

Hi @tinnet thanks for the PR!

Personally I am not against this functionality as it will not introduce breaking changes; but indeed we need to think about the usefulness of this feature.

You are right: without the style hint will people really click on the title to check the company? Emm... I am not super sure.

What do you think?

@tinnet
Copy link
Contributor Author

tinnet commented Jun 5, 2024

we could add an icon like 🔗 (fa: https://fontawesome.com/icons/link?f=classic&s=solid) but not sure how good that looks either e.g.

  if url != "" {
    society = [#society #link(url)[#fa-link(size: 8pt)]]
  }

i forgot to add that i took a clue from cvHonor that also has a "unstyled" link:

honorTitleStyle(title)
} else if url != "" {
[
#honorTitleStyle(link(url)[#title]), #honorIssuerStyle(issuer)
]
} else {

@tinnet
Copy link
Contributor Author

tinnet commented Jun 20, 2024

i've switched to using underlines in my cv after some feedback from people (instead of icons), i'll extract it and maybe add a "underLineLinks" config instead

@tinnet tinnet closed this Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants