Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken-links CLI bugs #178

Open
HowieG opened this issue May 9, 2024 · 3 comments
Open

broken-links CLI bugs #178

HowieG opened this issue May 9, 2024 · 3 comments

Comments

@HowieG
Copy link
Contributor

HowieG commented May 9, 2024

https://www.loom.com/share/6b1c711455514bcfb08d9f7cc894c857?sid=81952b0c-7317-4487-9dba-129227ad2c15

Hi, the broken-links command isn't working exactly as desired. I put broken-links as part of my CI/CD which was failing bc of this behavior so I had to take it out. Thanks!
@HowieG
Copy link
Contributor Author

HowieG commented May 9, 2024

On second thought I'll add back broken-links and just change the path to ./ so that I can keep broken-links in my CI/CD. But would still be great if this could be looked at :)

@Tarnadas
Copy link

Hey, I also have problems with the broken-links command and found this issue.
If your link has a dot "." anywhere in it, then the command reports these as a false positive. Presumably because the tool assumes that anything after the first dot is the file extension

@fikrikarim
Copy link

fikrikarim commented Jul 17, 2024 •
edited
Loading

I can confirm that we're also having issues with the broken-links command if the link has a dot "."

For example, this link would be flagged as a false positive:

upgrade/0.13.0

fikrikarim added a commit to makeswift/docs that referenced this issue Jul 17, 2024
@fikrikarim
fix: broken links
ddec294 
You can easily search for broken links by running the command:

mintlify broken-links

There are still 5 broken links because the CLI has a bug for a link that has dot ".":

mintlify/docs#178 (comment)
@fikrikarim fikrikarim mentioned this issue Jul 17, 2024
Merged
fikrikarim added a commit to makeswift/docs that referenced this issue Jul 17, 2024
@fikrikarim
fix: broken links
3d540bb 
You can easily search for broken links by running the command:

mintlify broken-links

There are still 5 broken links because the CLI has a bug for a link that has dot ".":

mintlify/docs#178 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tarnadas @fikrikarim @HowieG