Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA-37110: Add app.mintel.com/application to `podTargetLabels #347

Merged
merged 1 commit into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/standard-application-stack/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v7.5.0] - 2024-09-09
### Added
- Add `app.mintel.com/application` to `podTargetLabels` (ensures label is added to ingested metric)

## [v7.4.0] - 2024-08-27
### Added
- Set the `Application` ALB annotation tag on the Service resource. This propagates to the AWS TargetGroup as a tag.
Expand Down
2 changes: 1 addition & 1 deletion charts/standard-application-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 7.4.0
version: 7.5.0

dependencies:
- name: redis
Expand Down
2 changes: 1 addition & 1 deletion charts/standard-application-stack/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# standard-application-stack

![Version: 7.4.0](https://img.shields.io/badge/Version-7.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
![Version: 7.5.0](https://img.shields.io/badge/Version-7.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A generic chart to support most common application requirements

Expand Down
1 change: 1 addition & 0 deletions charts/standard-application-stack/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ app.kubernetes.io/component: app
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
{{- end -}}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Check additional PodMonitor resources:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -80,6 +81,7 @@ Check additional PodMonitor resources:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -123,6 +125,7 @@ Check additional PodMonitor resources:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -174,6 +177,7 @@ Check basic-auth:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -335,6 +339,7 @@ Check combined template defaults:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -500,6 +505,7 @@ Check combined template with extra ports and monitors:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -543,6 +549,7 @@ Check combined template with extra ports and monitors:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -586,6 +593,7 @@ Check combined template with extra ports and monitors:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -630,6 +638,7 @@ Check default endpoints:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -674,6 +683,7 @@ Check default targetLabels:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -718,6 +728,7 @@ Check metric overrides:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -762,6 +773,7 @@ Check name, namespace and labels:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ Check additional ServiceMonitor resources:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -114,6 +115,7 @@ Check additional ServiceMonitor resources:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -163,6 +165,7 @@ Check additional ServiceMonitor resources:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -220,6 +223,7 @@ Check basic-auth:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -387,6 +391,7 @@ Check combined template defaults:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -584,6 +589,7 @@ Check combined template with extra ports and monitors:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -633,6 +639,7 @@ Check combined template with extra ports and monitors:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -682,6 +689,7 @@ Check combined template with extra ports and monitors:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -764,6 +772,7 @@ Check default endpoints:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -814,6 +823,7 @@ Check default targetLabels:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -864,6 +874,7 @@ Check metric overrides:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down Expand Up @@ -914,6 +925,7 @@ Check name, namespace and labels:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
selector:
matchLabels:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ tests:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
- it: Check default endpoints
template: pod-monitor.yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ tests:
- app.kubernetes.io/part-of
- app.kubernetes.io/component
- app.kubernetes.io/instance
- app.mintel.com/application
- app.mintel.com/owner
- it: Check default endpoints
template: service-monitor.yaml
Expand Down
Loading