Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly call funcs & set log to info #2167

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jay-whitwell
Copy link
Contributor

@jay-whitwell jay-whitwell commented Nov 1, 2024

Purpose

Updates the cloud9 script to correctly call functions and shows the cleanup at info level

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the LPA service

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added mandatory tags to terraformed resources, where possible
  • If I have a new OPG component dependency, I have updated the metadata.json with the repo location.
  • If I added a package.json or composer.json, I also made sure this is included in the script in .github/workflows/dependabot-update.yml
  • The product team have tested these changes

@jay-whitwell jay-whitwell requested a review from a team as a code owner November 1, 2024 15:13
gillettmoj
gillettmoj previously approved these changes Nov 1, 2024
gillettmoj
gillettmoj previously approved these changes Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants