VEGA-2743 allow attorney details correction

[MishNajam]

Purpose

Updates the correction event to allow for attorney details to also be corrected

Fixes (VEGA-2743)

Approach

Implementation just adds to the current correction method

[hawx]

you could extract the address bit like:

func validateAddress(address *shared.Address) func(p *parse.Parser) []shared.FieldError {
	return func(p *parse.Parser) []shared.FieldError {
		return p.
			Field("/line1", &address.Line1, parse.Optional()).
			Field("/line2", &address.Line2, parse.Optional()).
			Field("/line3", &address.Line3, parse.Optional()).
			Field("/town", &address.Town, parse.Optional()).
			Field("/postcode", &address.Postcode, parse.Optional()).
			Field("/country", &address.Country, parse.Validate(func() []shared.FieldError {
				return validate.Country("", address.Country)
			}), parse.Optional()).
			Consumed()
	}
}

// validateAddress(&data.DonorAddress)
// validateAddress(&data.AttorneyAddress)

[hawx]

you could also use a similar technique to extract the /donor and /attorney handling if you wanted

[hawx]

maybe this would be neater, if it is going to grow, as

type Correction struct {
  Donor DonorCorrection
  LPASignedAt time.time
  Attorney AttorneyCorrection 
  // or if you can only have one of these pointers, then you can nil check to see which type it is?
}

type DonorCorrection struct { /* ... */ }
type AttorneyCorrection struct { /* ... */ }

[hawx]

then you'd also have the option of adding (c DonorCorrection/AttorneyCorrection) Apply(lpa *shared.Lpa) []shared.FieldError methods to break that up

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud