Skip to content

docs(contributions): fix back link not appearing, and fix previous pa… #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris Pymm (chrispymm) merged 1 commit into from
May 22, 2025
Merged

docs(contributions): fix back link not appearing, and fix previous pa… #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions helpers/previous-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,24 @@ const checkConditions = (conditions, session) => {
}

const previousPage = (url, session) => {
console.log('finding porevious page')
const pages = Object.keys(COMPONENT_FORM_PAGES)
const [currentPage, subpage] = url.split('/').slice(1) // split the url to get the page and subpage
const currentPageIndex = pages.findIndex((page) => currentPage.endsWith(page))
console.log(`current page index: ${currentPageIndex}`)

// Check if there are subpages in the session for the current page
if (subpage && Number.isInteger(Number(subpage)) && subpage > 1) {
return `${urlRoot}/${currentPage}/${subpage - 1}`
if (subpage && Number.isInteger(Number(subpage))) {
if(subpage > 1) {
return `${urlRoot}/${currentPage}/${subpage - 1}`
}

return `${urlRoot}/${currentPage}`
}

for (let i = currentPageIndex - 1; i >= 0; i--) {
const page = pages[i]
const conditions = COMPONENT_FORM_PAGES[page]
const conditions = COMPONENT_FORM_PAGES[page]?.conditions || {}
const shouldShowPage = checkConditions(conditions, session)

if (shouldShowPage) {
Expand Down
5 changes: 3 additions & 2 deletions views/common/base.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,8 +491,9 @@
</div>
<div class="app-layout__page app-page">

<main id="main-content" class="">{% block content %}
{{ content | safe }}
<main id="main-content" class="">
{% block content %}
{{ content | safe }}
{% endblock %}
</main>
</div>
Expand Down
Loading