fix(terraform-static-analysis): workaround TFLint issue #2591 attestation panic - #253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies a temporary workaround for terraform-linters/tflint#2591, where
tflint --initpanics in the attestation verification path due to GitHub's API now returningbundle: nulland only abundle_urlin attestation list responses.Changes
Attestation panic workaround (#2591)
GITHUB_TOKENunset in the action runtime to avoid the crashing attestation path.GITHUB_TOKENis still available later for PR comments.signature = "pgp"in bundled TFLint plugin configs so verification uses the PGP path instead of the broken attestation path.tflint --initexits non-zero.Plugin version bumps
tflint-ruleset-aws0.33.00.48.0tflint-ruleset-azurerm0.27.00.32.0tflint-ruleset-terraform0.9.10.15.0Configs updated:
tflint.aws.hcl,tflint.azure.hcl,tflint.default.hclDocs
terraform-static-analysis/README.md— noted the temporarysignature = "pgp"workaround and linked to the upstream fix PR.Validation
bash -n terraform-static-analysis/entrypoint.sh— no syntax errors.Follow-up
Remove the
signature = "pgp"lines and theenv -u GITHUB_TOKENwrapper once the upstream fix ships: