This repository has been archived by the owner on May 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates that during change to reference data CSVs,
start_date
/end_date
column pair)To bypass these validations, a new file has to be created
Currently, there's no check that
because it's failing, as it looks like we may need composite PK columns:
How does it work?
*.csv
files from a git reference, by defaultorigin/main
(VersionedRegisters
)CheckCompatibility
)(The thing is orchestrated by
App
)Why?
To make it extremely easy to update reference data for anyone (github text editor, basically). It also gives us history 🎉
And to provide guarantees for applications loading this data up that there won't be suddenly missing entries or incompatible payloads.
Notes
As the app already ignores test files, there's scope to introduce a convention to ignore certain files that are currently experimental, i.e. ones with
-draft
in them, or similar.