Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait until threads finish before sleeping #38

Merged
merged 2 commits into from
Mar 3, 2025
Merged

wait until threads finish before sleeping #38

merged 2 commits into from
Mar 3, 2025

Conversation

james-jdgtl
Copy link
Contributor

@james-jdgtl james-jdgtl commented Mar 3, 2025 •
edited
Loading

In case it helps avoid OOM due to a race condition:

  • maximum threads at 200,
  • joining up threads at the end before sleeping
  • reporting on memory at the beginning and the end of the run

Sandhya1874
Sandhya1874 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@Sandhya1874 Sandhya1874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-jdgtl james-jdgtl merged commit a541f34 into main Mar 3, 2025
2 checks passed
@james-jdgtl james-jdgtl deleted the bug/threads-wait-until-finish branch March 3, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandhya1874 Sandhya1874 Sandhya1874 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-jdgtl @Sandhya1874