Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display current filters #81

Merged
merged 10 commits into from
Mar 13, 2024
Merged

Display current filters #81

merged 10 commits into from
Mar 13, 2024

Conversation

thomasridd
Copy link
Contributor

@thomasridd thomasridd commented Mar 4, 2024

What

Display filters using patterns from manage-users view dps users

image

This has required a design iteration on how filters work in this application - code has extended to match this

Review note:
The enum GrantTypes has been changed to GrantType to bring it in line with other enums in the codebase - particularly ClientType with which it shares much common code - this accounts for a large quantity of file changes which are otherwise trivial

AlTurner-MOJ
AlTurner-MOJ previously approved these changes Mar 13, 2024
Copy link

@AlTurner-MOJ AlTurner-MOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Conflicts:
#	server/mappers/baseClientApi/listBaseClients.ts
Copy link

@AlTurner-MOJ AlTurner-MOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomasridd thomasridd merged commit 98a12c4 into main Mar 13, 2024
4 checks passed
@thomasridd thomasridd deleted the HAAR-display-current-filter branch March 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants