Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haar 2512 add service values #123

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Conversation

thomasridd
Copy link
Contributor

@thomasridd thomasridd commented Aug 2, 2024

Add service values to /base-clients/{base-client-id} page

image

Notes for review:
Functional changes are to...

  • server/interfaces/baseClientApi/baseClientResponse.ts
  • server/mappers/baseClientApi/getBaseClient.ts
  • server/views/pages/base-client.njk

Other changes files support these changes by adding and updating test frameworks or similar

Copy link

@AlTurner-MOJ AlTurner-MOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomasridd thomasridd merged commit 98bea81 into main Aug 8, 2024
4 checks passed
@thomasridd thomasridd deleted the HAAR-2512-add-service-values branch August 8, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants