Refactor determination javascript #6191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmhaig
force-pushed
the
refactor_determination_javascript
branch
6 times, most recently
from
9ca53a3 to
32c0493
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jrmhaig
force-pushed
the
refactor_determination_javascript
branch
from
32c0493 to
df855cd
Compare
jrmhaig
force-pushed
the
refactor_determination_javascript
branch
5 times, most recently
from
a02e9ff to
3ef1141
Compare
jrmhaig
commented
Jan 8, 2024
| } | ||
|
|
||
| cleanNumber = (element) => { | ||
| element.value = element.value.replaceAll(/[^\d.]/g, '').replace(/^(\d*\.\d\d).*$/, '$1') |
There was a problem hiding this comment.
There is a better way to do this by splitting the string on the first . to get the integer and mantissa parts and then remove all of the non-numeric characters from each part. As it is, a string like 12.3.4 does not get fixed.
|
jrmhaig
force-pushed
the
refactor_determination_javascript
branch
from
9dfa988 to
4afb768
Compare
... and without jQuery.
For some reason Response is not being recognised even though it is part of Javascript (https://caniuse.com/?search=Response). This is possibly due to out of date dependencies preventing ES6 coding standards being checkd. It is added to the list of globals to allow `yarn standard` to pass. It may be possible to remove this after refactoring.
jrmhaig
force-pushed
the
refactor_determination_javascript
branch
from
4afb768 to
7a33d4b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rewrite the javascript for calculating determinations to follow the GovUK Javascript style guide.
Ticket
N/A
Why
Some motivation is written in
docs/javascript_restructure.mdIn summary, the Javascript used in CCCD is written in inconsistent styles and have dependencies that are starting to make it difficult to keep the application up to date.
How
The determination calculation on the claim summary page for case workers was in
app/webpack/javascripts/modules/case_worker/claims/DeterminationCalculator.js. The new version is now inapp/webpack/javascripts/modules/determination.jsand tests are inapp/webpack/javascripts/modules/determination_spec.mjs.The GovUK
govuk-frontendmodule is enabled by adding the classgovuk-frontend-supportedto the<body>. This convention is for the newDeterminationclass. The class is initialised inapp/webpack/packs/govuk-frontend.jsin the same way asgovuk-frontendmodules are initialised byrequire('govuk-frontend').initAll().