Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DOCKER_API_VERSION from the docker-env command output #1655

Closed
hferentschik opened this issue Nov 3, 2017 · 0 comments
Closed

Remove DOCKER_API_VERSION from the docker-env command output #1655

hferentschik opened this issue Nov 3, 2017 · 0 comments
Assignees
@praveenkumar
Labels
kind/task priority/major resolution/done
Milestone
v1.10.0

Comments

@hferentschik
Copy link
Member

We used to add this variable as part of service-manager (while we were still Vagrant based) to avoid errors like:

Error response from daemon: client is newer than server (client API version: 1.22, server API version: 1.20)

See projectatomic/vagrant-service-manager#113

This was an issue with Docker daemon pre 1.12. See also moby/moby#21930 (comment)

Now that we are using a later version of Docker in the VM, there is no need for this anymore. Client and server use a negotiation algorithm now to determine the API version.
@coolbrg coolbrg added this to the v1.10.0 milestone Nov 9, 2017
@praveenkumar praveenkumar self-assigned this Nov 10, 2017
praveenkumar added a commit to praveenkumar/minishift that referenced this issue Nov 10, 2017
@praveenkumar
Issue minishift#1655 Remove Docker API version info from docker-env c…
0aa8f65 
…ommand
@praveenkumar praveenkumar mentioned this issue Nov 10, 2017
Merged
praveenkumar added a commit to praveenkumar/minishift that referenced this issue Nov 10, 2017
@praveenkumar
Issue minishift#1655 Remove Docker API version info from docker-env c…
17a5b80 
…ommand
coolbrg pushed a commit that referenced this issue Dec 6, 2017
@praveenkumar
Issue #1655 Remove Docker API version info from docker-env command
58cdb55
@tstromberg tstromberg mentioned this issue May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praveenkumar praveenkumar

Labels
kind/task priority/major resolution/done
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
4 participants
@hferentschik @praveenkumar @coolbrg @anjannath