Change NPM script to spawn with inherited STDIO #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me give this a proper try this time hehe |
|
Mind doing a quick changie batch auto + merge and we can get this out asap? |
|
Done, sorry, didn't see you responded that quickly 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #582
Check the following
Documentation changes are includedAdditional context
When I created the script I only tested the non-interactive commands (where pipe was enough). I also forgot to pipe the
stdinchannel, but that wouldn't have fixed the problem.After doing a bit more research, the
inheritoption direct maps node's stdio channels to the spawned child process, which is what we actually want.