-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple code improvements - squid:S1192, squid:S1166, squid:S1172, squid:S1213, squid:S1155, squid:UselessImportCheck #402
Multiple code improvements - squid:S1192, squid:S1166, squid:S1172, squid:S1213, squid:S1155, squid:UselessImportCheck #402
Conversation
|
||
|
||
/** | ||
* Identifies and stores version information of minio-java package at run time. | ||
*/ | ||
enum MinioProperties { | ||
INSTANCE; | ||
|
||
private static final Logger LOGGER = Logger.getLogger(HeaderParser.class.getName()); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshavardhana please check whether its ok.
You would need to fix appveyor/travis-ci builds |
@@ -16,19 +16,26 @@ | |||
|
|||
package io.minio; | |||
|
|||
import io.minio.http.HeaderParser; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see HeaderParser
is not used here. Is this import needed?
@georgekankava please rebase this pull request. |
@balamurugana sorry for the delay. I have rebased the PR. |
LGTM. Please fix below stylecheck error from gradle build
|
@balamurugana I am about to fix the checkstyle errors. |
…quid:S1213, squid:S1155, squid:UselessImportCheck
@balamurugana updated. |
LGTM |
This pull request is focused on resolving occurrences of Sonar rules
squid:S1192 - String literals should not be duplicated.
squid:S1166 - Exception handlers should preserve the original exception.
squid:S1172 - Unused method parameters should be removed.
squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order.
squid:S1155 - Collection.isEmpty() should be used to test for emptiness.
squid:UselessImportCheck - Useless imports should be removed.
This pull request removes 42 minutes of technical debt.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1192
https://dev.eclipse.org/sonar/rules/show/squid:S1166
https://dev.eclipse.org/sonar/rules/show/squid:S1172
https://dev.eclipse.org/sonar/rules/show/squid:S1213
https://dev.eclipse.org/sonar/rules/show/squid:S1155
https://dev.eclipse.org/sonar/rules/show/squid:UselessImportCheck
Please let me know if you have any questions.
George Kankava