Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IamAwsProvider: fix custom endpoint having non-default port #1523

Merged
merged 5 commits into from
Mar 2, 2024
Merged

IamAwsProvider: fix custom endpoint having non-default port #1523

merged 5 commits into from
Mar 2, 2024

Conversation

jgolda
Copy link
Contributor

@jgolda jgolda commented Jan 15, 2024 •
edited by balamurugana
Loading

Follow-up to #1522

@jgolda
Copy link
Contributor Author

jgolda commented Jan 16, 2024

As to the pipeline errors they are most likely unrelated to my changes - same error occurs on master branch and the class i touched is not used during the testes, so it should not affect them. I manually tested the built library in an example app based on the FileUploader from project's README, just to authenticate and call an API method.

As far as i recall the tests fail because min.io instance expected to run TLS is not running TLS, hence giving this error.
I'll try to research it in the evening - if you have any ideas as to how to fix it, i'll also appreciate it

@jgolda jgolda mentioned this pull request Jan 16, 2024
Merged
@balamurugana balamurugana marked this pull request as draft January 17, 2024 01:51
@balamurugana balamurugana changed the title Support for non-default port in custom endpoint for AWS IAM credentials provider IamAwsProvider: fix custom endpoint having non-default port Jan 17, 2024
@balamurugana balamurugana marked this pull request as ready for review January 17, 2024 04:04
@bh4t bh4t added the community label Feb 5, 2024
balamurugana
balamurugana requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As okhttp3.HttpUrl is taking care of default port for http and https, this commit should be reverted

api/src/main/java/io/minio/credentials/IamAwsProvider.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/credentials/IamAwsProvider.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/credentials/IamAwsProvider.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/credentials/IamAwsProvider.java Outdated Show resolved Hide resolved
@minio-trusted minio-trusted merged commit 293d811 into minio:master Mar 2, 2024
8 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana approved these changes

@minio-trusted minio-trusted minio-trusted approved these changes

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgolda @balamurugana @minio-trusted @bh4t