Improve put object performance by sending sha256sum always. #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `UNSIGNED-PAYLOAD` is sent sha256sum and computed md5sum of body for HTTPS and computed sha256sum/md5sum of body for HTTP. This made the API slower. Now computed sha256sum is always sent for both HTTP and HTTPS. Fixes minio#1332 Signed-off-by: Bala.FA <[email protected]>
harshavardhana
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
UNSIGNED-PAYLOADis sent sha256sum and computed md5sumof body for HTTPS and computed sha256sum/md5sum of body for HTTP. This
made the API slower. Now computed sha256sum is always sent for both
HTTP and HTTPS.
Fixes #1332
Signed-off-by: Bala.FA [email protected]