Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods on operations helper #839

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

tvdias
Copy link
Contributor

@tvdias tvdias commented Aug 11, 2023

It looks like there are some unused private methods on Helper/OperationsHelper.cs. I've removed them, as I couldn't see anything being broken. On GetObjectHelper there was also an else if that controlled if CallBack or FuncCallBack should be executed, but this logic was not in use. This else if is now merged with the else.

image

@tvdias tvdias marked this pull request as ready for review August 14, 2023 09:46
@ebozduman ebozduman merged commit e1ef9f5 into minio:master Aug 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants