Bucket Lifecycle configuration APIs(Get, Set, Remove) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigUstad
force-pushed
the
1-minio-dotnet-lifecycle
branch
2 times, most recently
from
13809e1
to
f330071
Compare
kannappanr
reviewed
Jan 7, 2021
| @@ -0,0 +1,54 @@ | |||
| /* | |||
| * MinIO .NET Library for Amazon S3 Compatible Cloud Storage, (C) 2020 MinIO, Inc. | |||
There was a problem hiding this comment.
Suggested change
| * MinIO .NET Library for Amazon S3 Compatible Cloud Storage, (C) 2020 MinIO, Inc. | |
| * MinIO .NET Library for Amazon S3 Compatible Cloud Storage, (C) 2021 MinIO, Inc. |
kannappanr
reviewed
Jan 7, 2021
| @@ -0,0 +1,38 @@ | |||
| /* | |||
There was a problem hiding this comment.
shouldn't this be under ilm folder?
kannappanr
reviewed
Jan 7, 2021
| @@ -430,6 +430,9 @@ public override RestRequest BuildRequest(RestRequest request) | |||
| request.AddQueryParameter("tagging",""); | |||
| string body = this.BucketTags.MarshalXML(); | |||
| request.AddParameter(new Parameter("text/xml", body, ParameterType.RequestBody)); | |||
| request.AddOrUpdateParameter("Content-MD5", | |||
There was a problem hiding this comment.
is this computed for all operations?
There was a problem hiding this comment.
All operations with XML configuration attached, we get an exception if 'Content-MD5' is missing
BigUstad
force-pushed
the
1-minio-dotnet-lifecycle
branch
7 times, most recently
from
6287cee
to
2f13b7d
Compare
krisis
approved these changes
Jan 11, 2021
BigUstad
force-pushed
the
1-minio-dotnet-lifecycle
branch
from
2f13b7d
to
72f032d
Compare
BigUstad
force-pushed
the
1-minio-dotnet-lifecycle
branch
from
72f032d
to
c835d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Args, Examples & Functional test