Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing github action warnings. #505

Merged
merged 5 commits into from
Dec 31, 2020

Conversation

BigUstad
Copy link
Contributor

  • Fixing missing closing/opening XML tags.
  • Removing instances of Parameter (IRestResponse, RestRequest), if possible
  • In Functional Tests removing async for some calls.
  • Marking some functions as obsolete if missing, changing accordingly.
  • Removing unused, initialized variable.
  • Removing unnecessary 'using' statements.

@BigUstad BigUstad force-pushed the 1-minio-dotnet-actions-warning branch from 866f064 to e55f9d9 Compare December 19, 2020 06:56
@BigUstad BigUstad force-pushed the 1-minio-dotnet-actions-warning branch 4 times, most recently from 698723f to 9d44901 Compare December 22, 2020 07:22
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigUstad

There are still GitHub Actions warnings in Minio/ApiEndpoints/BucketOperations.cs file:
Example:

Check warning on line 90 in Minio/ApiEndpoints/BucketOperations.cs

GitHub Actions
/ build (Release)
Minio/ApiEndpoints/BucketOperations.cs#L90
The method 'MakeBucketAsync' do not need to use async/await.

See Minio/ApiEndpoints/BucketOperations.cs file under Files Changed of this PR.

I also see total 67 warnings during dotnet build. This list also includes the above GitHub Actions warnings.
They look like all belong to your to be fixed list in this PR's description/
Here is the short list of those warnings.

(32) The method '<method-name>' do not need to use async/await
(28) MinioClient.<object-builder-name(...)> is obsolete
(4) CopyToAsync should be used instead of stream.CopyTo
(2) Initialize is a fire & forget async void method
(1) This async method lacks 'await' operators and will run synchronously.

@BigUstad
Copy link
Contributor Author

@BigUstad

There are still GitHub Actions warnings in Minio/ApiEndpoints/BucketOperations.cs file:
Example:

Check warning on line 90 in Minio/ApiEndpoints/BucketOperations.cs

GitHub Actions
/ build (Release)
Minio/ApiEndpoints/BucketOperations.cs#L90
The method 'MakeBucketAsync' do not need to use async/await.

See Minio/ApiEndpoints/BucketOperations.cs file under Files Changed of this PR.

I also see total 67 warnings during dotnet build. This list also includes the above GitHub Actions warnings.
They look like all belong to your to be fixed list in this PR's description/
Here is the short list of those warnings.

(32) The method '<method-name>' do not need to use async/await
(28) MinioClient.<object-builder-name(...)> is obsolete
(4) CopyToAsync should be used instead of stream.CopyTo
(2) Initialize is a fire & forget async void method
(1) This async method lacks 'await' operators and will run synchronously.

The "do not need to use async/await" is definitely wrong as async/await combination is definitely needed. So a workaround is needed for this warning. I'm looking into it.
I'll also look into the obsolete warnings

@BigUstad BigUstad force-pushed the 1-minio-dotnet-actions-warning branch 2 times, most recently from d58870c to 7df482a Compare December 24, 2020 09:02
@BigUstad
Copy link
Contributor Author

@ebozduman Please try with the latest patchset.

@BigUstad BigUstad force-pushed the 1-minio-dotnet-actions-warning branch 4 times, most recently from d3bb878 to f223445 Compare December 29, 2020 08:42
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priyank said he'll address the last 2 warnings about stream.CopyTo.
So, LGTM

@BigUstad BigUstad force-pushed the 1-minio-dotnet-actions-warning branch 3 times, most recently from 29291f1 to 5162fff Compare December 30, 2020 09:47
@BigUstad BigUstad force-pushed the 1-minio-dotnet-actions-warning branch from 5162fff to 589a9b0 Compare December 31, 2020 01:34
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 8ec6c36 into minio:master Dec 31, 2020
@BigUstad BigUstad deleted the 1-minio-dotnet-actions-warning branch January 7, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants