Bucket Encryption API. #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example, Functional test
BigUstad
force-pushed
the
minio-dotnet-bucketencryption
branch
from
c3873d8
to
b8c8536
Compare
BigUstad
force-pushed
the
minio-dotnet-bucketencryption
branch
from
67a519a
to
4f91569
Compare
kannappanr
reviewed
Dec 9, 2020
| @@ -69,8 +69,9 @@ public class FunctionalTest | |||
| private const string getBucketPolicySignature = "Task<string> GetPolicyAsync(GetPolicyArgs args, CancellationToken cancellationToken = default(CancellationToken))"; | |||
| private const string setBucketPolicySignature = "Task SetPolicyAsync(SetPolicyArgs args, CancellationToken cancellationToken = default(CancellationToken))"; | |||
| private const string getBucketNotificationSignature = "Task<BucketNotification> GetBucketNotificationAsync(GetBucketNotificationsArgs args, CancellationToken cancellationToken = default(CancellationToken))"; | |||
| private const string setBucketNotificationSignature = "Task SetBucketNotificationAsync(SetBucketNotificationsArgs args, CancellationToken cancellationToken = default(CancellationToken))"; | |||
| private const string setBucketNotificationSignature = "Task SetBucketNotificationAsync(SetBucketEncryptionArgs args, CancellationToken cancellationToken = default(CancellationToken))"; | |||
There was a problem hiding this comment.
Suggested change
| private const string setBucketNotificationSignature = "Task SetBucketNotificationAsync(SetBucketEncryptionArgs args, CancellationToken cancellationToken = default(CancellationToken))"; | |
| private const string setBucketNotificationSignature = "Task SetBucketNotificationAsync(SetBucketNotificationsArgs args, CancellationToken cancellationToken = default(CancellationToken))"; |
There was a problem hiding this comment.
Changed. More tests added to the function.
BigUstad
force-pushed
the
minio-dotnet-bucketencryption
branch
3 times, most recently
from
262eedd
to
dadc8f4
Compare
BigUstad
force-pushed
the
minio-dotnet-bucketencryption
branch
from
dadc8f4
to
8f5f285
Compare
Praveenrajmani
approved these changes
Dec 16, 2020
sinhaashish
approved these changes
Dec 16, 2020
BigUstad
force-pushed
the
minio-dotnet-bucketencryption
branch
3 times, most recently
from
94240dc
to
e9b311f
Compare
BigUstad
force-pushed
the
minio-dotnet-bucketencryption
branch
from
e9b311f
to
8d1b7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example, Functional test