GetObject API with Args & Response objects. #473

BigUstad · 2020-10-20T22:05:43Z

Versioning related code included. Examples added for versioning & conditional matches.

Minio.Examples/Cases/GetObjectQuery.cs

Versioning related code included. Examples added for versioning & conditional matches.

poornas · 2020-11-17T07:23:02Z

Minio.Examples/Cases/GetObjectQuery.cs

+                                                .WithMatchETag(matchEtag)
+                                                .WithNotMatchETag(notMatchEtag)
+                                                .WithModifiedSince(modifiedSince)
+                                                .WithUnModifiedSince(unModifiedSince);


please remove conflicting options from the example

poornas · 2020-11-17T07:24:57Z

Minio.Examples/Cases/StatObjectQuery.cs

+            }
+        }
+    }
+}


this example pertains to PR #472 . Can it be removed?

poornas · 2020-11-17T07:26:13Z

Minio.Functional.Tests/FunctionalTest.cs

-        private const string getObjectSignature3 = "Task GetObjectAsync(string bucketName, string objectName, string fileName, CancellationToken cancellationToken = default(CancellationToken))";
+        private const string getObjectSignature1 = "Task GetObjectAsync(GetObjectArgs args, CancellationToken cancellationToken = default(CancellationToken))";
+        private const string getObjectSignature2 = "Task GetObjectAsync(GetObjectArgs args, CancellationToken cancellationToken = default(CancellationToken))";
+        private const string getObjectSignature3 = "Task GetObjectAsync(GetObjectArgs args, CancellationToken cancellationToken = default(CancellationToken))";


they now have same signature - please remove the duplicates

I've not pushed the resolved conflicts files yet. I will do it soon.

poornas · 2020-11-17T18:13:08Z

Minio/DataModel/ServerSideEncryption.cs

+        public string GetCustomerKeyMD5()
+        {
+            return utils.getMD5SumStr(this.key);
+        }


Didn't we decide in previous reviews that this method is unnecessary

I've not pushed the resolved conflicts files yet. I will do it soon.

poornas · 2020-11-23T19:04:44Z

can you rebase this PR @BigUstad

BigUstad · 2020-11-23T19:41:07Z

can you rebase this PR @BigUstad

Yes @poornas I'm rebasing all PRs that needs merging.

poornas

github actions reported warnings/errors need to be fixed.

Minio/DataModel/ObjectOperationsArgs.cs

poornas · 2020-11-25T00:11:14Z

Minio/DataModel/ServerSideEncryption.cs

+        public string GetCustomerKeyMD5()
+        {
+            return utils.getMD5SumStr(this.key);
+        }


Minio/DataModel/ServerSideEncryption.cs

poornas · 2020-11-25T00:11:46Z

Minio/DataModel/ServerSideEncryption.cs

+        public string GetCustomerKeyMD5()
+        {
+            return null;
+        }


this method is not required.

Minio/Helper/OperationsHelper.cs

poornas · 2020-11-25T00:20:39Z

Minio.Functional.Tests/FunctionalTest.cs

-        private const string getObjectSignature3 = "Task GetObjectAsync(string bucketName, string objectName, string fileName, CancellationToken cancellationToken = default(CancellationToken))";
+        private const string getObjectSignature1 = "Task GetObjectAsync(GetObjectArgs args, CancellationToken cancellationToken = default(CancellationToken))";
+        private const string getObjectSignature2 = "Task GetObjectAsync(GetObjectArgs args, CancellationToken cancellationToken = default(CancellationToken))";
+        private const string getObjectSignature3 = "Task GetObjectAsync(GetObjectArgs args, CancellationToken cancellationToken = default(CancellationToken))";


poornas

LGTM

kannappanr · 2020-11-26T14:25:47Z

Minio/Helper/OperationsHelper.cs

+
+            utils.ValidateFile(tempFileName);
+
+            FileInfo tempFileInfo = new FileInfo(tempFileName);


can this be moved inside the if condition code

Yes. Changed.

…bject

kannappanr · 2020-12-07T20:48:31Z

Minio/DataModel/ObjectOperationsArgs.cs

@@ -363,7 +365,7 @@ public PresignedPutObjectArgs WithExpiry(int ex)
        }
    }

-    public class RemoveUploadArgs : EncryptionArgs<RemoveUploadArgs>
+public class RemoveUploadArgs : EncryptionArgs<RemoveUploadArgs>


indentation

Noted, changed.

kannappanr · 2020-12-07T21:37:49Z

Minio/DataModel/ObjectOperationsArgs.cs

+
+                if (this.ObjectLength < 0)
+                {
+                    throw new ArgumentException("Length should be greater than zero", nameof(this.ObjectLength));


message should be greater than or equal to

Changed the message & the condition.

kannappanr · 2020-12-07T21:38:18Z

Minio/DataModel/ObjectOperationsArgs.cs

@@ -335,7 +337,7 @@ public PresignedPostPolicyArgs WithPolicy(PostPolicy policy)
        {
            this.Policy = policy;
            return this;
-        }
+        }    


why is there an extra space

Happened during vscode 'Accept Both changes'. Removing.

kannappanr · 2020-12-07T21:43:21Z

Minio/Helper/OperationsHelper.cs

+            {
+                FileInfo tempFileInfo = new FileInfo(tempFileName);
+                tempFileSize = tempFileInfo.Length;
+                if (tempFileSize > length)


what if tempFileSize is < length?

kannappanr · 2020-12-14T03:51:35Z

Minio/Helper/OperationsHelper.cs

+            }
+            if (File.Exists(args.FileName))
+            {
+                File.Delete(tempFileName);


Suggested change

File.Delete(tempFileName);

File.Delete(args.FileName);

Changing that.

Minio/Helper/OperationsHelper.cs

…bject

kannappanr

LGTM

kannappanr reviewed Oct 20, 2020

View reviewed changes

Minio.Examples/Cases/GetObjectQuery.cs Outdated Show resolved Hide resolved

GetObject API with Args & Response objects.

664eca5

Versioning related code included. Examples added for versioning & conditional matches.

BigUstad force-pushed the 1-minio-dotnet-getobject branch from 7a9782c to 664eca5 Compare November 5, 2020 06:27

GetObject API with Args & Response objects.

efadd87

BigUstad force-pushed the 1-minio-dotnet-getobject branch from 8fa269f to efadd87 Compare November 6, 2020 21:52

GetObject API with Args & Response objects

b9c190b

BigUstad force-pushed the 1-minio-dotnet-getobject branch from 5246bdb to b9c190b Compare November 12, 2020 04:07

kannappanr requested a review from poornas November 16, 2020 23:11

poornas requested changes Nov 17, 2020

View reviewed changes

BigUstad force-pushed the 1-minio-dotnet-getobject branch 5 times, most recently from 8a05618 to f20205f Compare November 24, 2020 20:30

poornas requested changes Nov 25, 2020

View reviewed changes

BigUstad force-pushed the 1-minio-dotnet-getobject branch from f20205f to e36fc2e Compare November 25, 2020 06:47

poornas approved these changes Nov 26, 2020

View reviewed changes

kannappanr reviewed Nov 26, 2020

View reviewed changes

GetObject API with Args & Response objects.

3fee192

BigUstad force-pushed the 1-minio-dotnet-getobject branch from e36fc2e to 3fee192 Compare November 27, 2020 06:57

BigUstad added 3 commits November 27, 2020 22:21

Merge remote-tracking branch 'origin/master' into 1-minio-dotnet-geto…

3a35479

…bject

Merge remote-tracking branch 'origin/master' into 1-minio-dotnet-geto…

327bcc6

…bject

Merge remote-tracking branch 'origin/master' into 1-minio-dotnet-geto…

b4494df

…bject

BigUstad force-pushed the 1-minio-dotnet-getobject branch from cdeade3 to 7191d57 Compare December 7, 2020 17:24

kannappanr reviewed Dec 7, 2020

View reviewed changes

BigUstad force-pushed the 1-minio-dotnet-getobject branch 2 times, most recently from 1d9afa2 to d6054ac Compare December 7, 2020 21:12

kannappanr reviewed Dec 7, 2020

View reviewed changes

BigUstad force-pushed the 1-minio-dotnet-getobject branch 3 times, most recently from 2e7c0b4 to 5225f13 Compare December 8, 2020 17:35

kannappanr reviewed Dec 14, 2020

View reviewed changes

Minio/Helper/OperationsHelper.cs Show resolved Hide resolved

GetObject API with Args & Response objects.

f41d5e7

BigUstad force-pushed the 1-minio-dotnet-getobject branch from 5225f13 to f41d5e7 Compare December 14, 2020 18:58

Merge remote-tracking branch 'origin/master' into 1-minio-dotnet-geto…

ea5cab9

…bject

kannappanr approved these changes Dec 21, 2020

View reviewed changes

kannappanr merged commit b61b0c7 into minio:master Dec 21, 2020

BigUstad deleted the 1-minio-dotnet-getobject branch December 21, 2020 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GetObject API with Args & Response objects. #473

GetObject API with Args & Response objects. #473

BigUstad commented Oct 20, 2020

poornas Nov 17, 2020

poornas Nov 17, 2020

poornas Nov 17, 2020

BigUstad Nov 17, 2020

poornas Nov 25, 2020

poornas Nov 17, 2020

BigUstad Nov 17, 2020

poornas Nov 25, 2020

poornas commented Nov 23, 2020

BigUstad commented Nov 23, 2020

poornas left a comment

poornas Nov 25, 2020

poornas Nov 25, 2020

poornas Nov 25, 2020

poornas left a comment

kannappanr Nov 26, 2020

BigUstad Nov 27, 2020

kannappanr Dec 7, 2020

BigUstad Dec 7, 2020

kannappanr Dec 7, 2020

BigUstad Dec 8, 2020

kannappanr Dec 7, 2020

BigUstad Dec 8, 2020

kannappanr Dec 7, 2020

kannappanr Dec 14, 2020

BigUstad Dec 14, 2020

kannappanr left a comment


		utils.ValidateFile(tempFileName);

		FileInfo tempFileInfo = new FileInfo(tempFileName);

GetObject API with Args & Response objects. #473

GetObject API with Args & Response objects. #473

Conversation

BigUstad commented Oct 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

poornas commented Nov 23, 2020

BigUstad commented Nov 23, 2020

poornas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

poornas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kannappanr left a comment

Choose a reason for hiding this comment