Adds missing parts of the fix in PR #1110 #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondeklein
requested changes
Jul 16, 2024
harshavardhana
approved these changes
Jul 21, 2024
ramondeklein
requested changes
Jul 22, 2024
ramondeklein
approved these changes
Jul 24, 2024
ramondeklein
added a commit
to ramondeklein/minio-dotnet
that referenced
this pull request
Dec 19, 2024
This reverts commit 93007be. # Conflicts: # Minio/Minio.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #1110 is merged, the functional test case added in PR #1110 started failing sporadically but frequently.
This PR fixes the timing issue and there were bunch of unnecessary code that is removed.