deprecate mc quota #1294
Merged
deprecate mc quota #1294
+105
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feorlen
commented
Aug 7, 2024
| @@ -51,6 +51,22 @@ Table of Deprecated Commands | |||
| - :mc-cmd:`mc ilm rule rm` | |||
| - mc RELEASE.2022-12-24T15-21-38Z | |||
|
|
|||
| * - ``mc quota`` | |||
There was a problem hiding this comment.
Not entirely sure what to do about mc quota itself. There's important information there about how bucket quota works (and why it's not what people think it is). So I don't want to just drop its page.
Maybe put that information into the deprecated mc quota set page instead? 🤔
There was a problem hiding this comment.
Ok, did the above so there's no mc quota page under deprecated.
feorlen
commented
Aug 7, 2024
Comment on lines
+26
to
+34
| When a bucket with a quota configured reaches the specified limit, as determined by the MinIO object scanner, MinIO rejects further ``PUT`` requests for the bucket. | ||
|
|
||
| Each time the MinIO :ref:`object scanner <minio-lifecycle-management-scanner>` scans a bucket for pending :ref:`object lifecycle transitions <minio-lifecycle-management>`, it also checks if the bucket has exceeded a configured quota. | ||
|
|
||
| .. admonition:: Quota enforcement is not immediate | ||
| :class: note | ||
|
|
||
| Bucket quotas are not intended to enforce a strict hard limit on a bucket's size. | ||
| If a bucket exceeds its quota between scanner passes, MinIO continues to accept ``PUT`` requests for that bucket until _after_ the next scanner pass identifies the quota violation. |
There was a problem hiding this comment.
New content here, which is hard to tell because GitHub thinks the whole page is "new"
ravindk89
approved these changes
Aug 8, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bucket quotas don't work the way people think they work, as they cannot enforce hard limits. Deprecate in docs while we sort out what to do with the commands.
The future replacement is MinIO Enterprise Catalog.
Staged:
http://192.241.195.202:9000/staging/deprecate-bucket-quota/linux/reference/minio-mc-deprecated.html
See:
minio/mc#5011
minio/mc#5012